From patchwork Tue May 8 20:40:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 910460 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cQcdHn9+"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40gWbG5NYwz9s3G for ; Wed, 9 May 2018 06:40:42 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4B65225CFE; Tue, 8 May 2018 20:40:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8KyRiGxBf2MF; Tue, 8 May 2018 20:40:34 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 6849125B0F; Tue, 8 May 2018 20:40:33 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 885581C26CB for ; Tue, 8 May 2018 20:40:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 819DF86793 for ; Tue, 8 May 2018 20:40:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wUg6FcCIpJdw for ; Tue, 8 May 2018 20:40:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 831A0866A9 for ; Tue, 8 May 2018 20:40:28 +0000 (UTC) Received: by mail-wm0-f68.google.com with SMTP id w194so20833298wmf.2 for ; Tue, 08 May 2018 13:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=LBfFIseE6bkcIOghkPJWmjZ3ex0cCNlvrbdyAc6zDSA=; b=cQcdHn9+1dmxOzx7Q2IcXXVBBSGHV6QsbnO+JYmOhFm9VToYQkeVYgIHh//jCDnzEx GQXmnMpwjQwe3thp/wPAB9VZIBfndO7cGsPJ5fc6fROQopGJEhdLOvYVb1HpFGc5I5ZY 0wu5oWeeFqM3LA1JKzrWzwyiQxNn6XoyhCfMkdlZ1voXTz6fATNnIN0kvnfTGkG+ock/ 224es8KliMvS8cohdTN2KC8TqGfOdr/O4RJDNtgW/TrlhCT/zc7tn3zwACmfsycD1KPO G/vnwXiE9XkJXc8uFl1VNSjXIPSjfoSSPKkRLNj8ic4oOnKqzEo+718N1miS0lCqWt8Q uWcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=LBfFIseE6bkcIOghkPJWmjZ3ex0cCNlvrbdyAc6zDSA=; b=N60FYnUPJrVHYlaEi43czcZjSv0RvyWeLob4bf2rLvT2o7rlBJlzLL6AABit/6+rHO iiEqDk1ijMO4031+R1rKlRM0kN9Zkl4VryBvTIAk/UhAIkRGXNnBHvFJhFMx0unG2HkW xKvhEJpYsX1+fjXaF6ZcX+6oQPkrpxNOH9YqlDHPYXTPmI6kSF2cNhpIYooomMufKxUW 9naeGcTSk5m4/fVSOHp57nXhsmeaUwxXOyhY+YqThK7uvoAIM0qGESiYPYComTp8dFxd rOWwpOAUOXJmGoI1YAgiaHxZnSLJigQ+g+wJSLdEbfkjZ1Dyy1xax3hsFZ0b8XwGAdjc 5tQQ== X-Gm-Message-State: ALKqPwcsuq4inRLt0ShW8tYrqs4Q31Hny9XbF2KsjLmQzluTpT4CuFdm HEhMjxef7pLW8Ac1ncVmKLsciw== X-Google-Smtp-Source: AB8JxZqUE0y8NEy0TnNIYTnu9ISu/kdTaLH1qLC63N58ue7Mif3lKBjJq8g2aw9yNtRhMf2NIBS+/w== X-Received: by 10.28.111.82 with SMTP id k79mr3869312wmc.38.1525812026885; Tue, 08 May 2018 13:40:26 -0700 (PDT) Received: from scaer.bzh.lan (2a01cb0886107300517c0c28e3b77189.ipv6.abo.wanadoo.fr. [2a01:cb08:8610:7300:517c:c28:e3b7:7189]) by smtp.gmail.com with ESMTPSA id v75-v6sm38772308wrc.65.2018.05.08.13.40.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 13:40:26 -0700 (PDT) From: "Yann E. MORIN" To: buildroot@buildroot.org Date: Tue, 8 May 2018 22:40:20 +0200 Message-Id: X-Mailer: git-send-email 2.14.1 In-Reply-To: References: Subject: [Buildroot] [PATCH 7/7 v2] fs: always depend on build host-tar if needed X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yann E. MORIN" , Thomas Petazzoni MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Currently, the filesystems do not depend on building host-tar when it is needed, even though all of them have to extract the intermediate tarball. However, in degenerate (but legally valid) configurations with no user-selectable package selected, host-tar would not be built, so the rootfs images would use whatever improper tar the system has. Add the conditional dependency to host-tar to the rootfs-common intermediate image. Since this is the internal step that all real rootfs generators depend on, they now properly depend on host-tar when needed. In practice, when host-tar is needed, it will always be built before the rootfs inages, because it is a dependency of all packages (except a very few, like the skeleton), of which host-fakeroot, which is a mandatory dependency of rootfs-comon anyway. But for consistency sake, let's explicitly add host-tar as a dependency to rootfs-common too. Note that rootfs-tar already had that dependency, and we leave it as-is because it is semantically correct, even if superfluous. Signed-off-by: "Yann E. MORIN" Cc: Thomas Petazzoni --- Note: yes, I had a randpackageconfig turn up a configuration with no user-selectable package enabled... I should just stop coding and go play bingo. Too bad there is no big jackpot tonight... ;-] --- fs/common.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/common.mk b/fs/common.mk index 9baf367729..d106783813 100644 --- a/fs/common.mk +++ b/fs/common.mk @@ -63,6 +63,7 @@ ROOTFS_COMMON_TARGET_DIR = $(FS_DIR)/target ROOTFS_COMMON_DEPENDENCIES = \ host-fakeroot host-makedevs \ + $(BR2_TAR_HOST_DEPENDENCY) \ $(if $(PACKAGES_USERS)$(ROOTFS_USERS_TABLES),host-mkpasswd) $(ROOTFS_COMMON_TAR): ROOTFS=COMMON