Message ID | 20180508114403.14499-3-mperttunen@nvidia.com |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | Tegra Combined UART driver | expand |
On 08/05/18 12:43, Mikko Perttunen wrote: > Add bindings for the Tegra Combined UART device used to talk to the > UART console on Tegra194 systems. > > Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> > --- > .../bindings/serial/nvidia,tegra194-tcu.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt > > diff --git a/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt b/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt > new file mode 100644 > index 000000000000..86763bc5d74f > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt > @@ -0,0 +1,35 @@ > +NVIDIA Tegra Combined UART (TCU) > + > +The TCU is a system for sharing a hardware UART instance among multiple > +systems withing the Tegra SoC. It is implemented through a mailbox- > +based protocol where each "virtual UART" has a pair of mailboxes, one > +for transmitting and one for receiving, that is used to communicate > +with the hardware implementing the TCU. > + > +Required properties: > +- name : Should be tcu > +- compatible > + Array of strings > + One of: > + - "nvidia,tegra194-tcu" Nit. We should say what device the above compatibility is applicable for ... - "nvidia,tegra194-tcu": for Tegra194 Cheers Jon
On Tue, May 22, 2018 at 04:15:09PM +0100, Jon Hunter wrote: > > On 08/05/18 12:43, Mikko Perttunen wrote: > > Add bindings for the Tegra Combined UART device used to talk to the > > UART console on Tegra194 systems. > > > > Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> > > --- > > .../bindings/serial/nvidia,tegra194-tcu.txt | 35 ++++++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt > > > > diff --git a/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt b/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt > > new file mode 100644 > > index 000000000000..86763bc5d74f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt > > @@ -0,0 +1,35 @@ > > +NVIDIA Tegra Combined UART (TCU) > > + > > +The TCU is a system for sharing a hardware UART instance among multiple > > +systems withing the Tegra SoC. It is implemented through a mailbox- > > +based protocol where each "virtual UART" has a pair of mailboxes, one > > +for transmitting and one for receiving, that is used to communicate > > +with the hardware implementing the TCU. > > + > > +Required properties: > > +- name : Should be tcu > > +- compatible > > + Array of strings > > + One of: > > + - "nvidia,tegra194-tcu" > > Nit. We should say what device the above compatibility is applicable for ... > > - "nvidia,tegra194-tcu": for Tegra194 Yeah, everyone seems to do that, but I find it to be redundant. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 08, 2018 at 02:43:57PM +0300, Mikko Perttunen wrote: > Add bindings for the Tegra Combined UART device used to talk to the > UART console on Tegra194 systems. > > Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> > --- > .../bindings/serial/nvidia,tegra194-tcu.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt > > diff --git a/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt b/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt > new file mode 100644 > index 000000000000..86763bc5d74f > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt > @@ -0,0 +1,35 @@ > +NVIDIA Tegra Combined UART (TCU) > + > +The TCU is a system for sharing a hardware UART instance among multiple > +systems withing the Tegra SoC. It is implemented through a mailbox- s/withing/within/ Otherwise, Reviewed-by: Rob Herring <robh@kernel.org> > +based protocol where each "virtual UART" has a pair of mailboxes, one > +for transmitting and one for receiving, that is used to communicate > +with the hardware implementing the TCU. > + > +Required properties: > +- name : Should be tcu > +- compatible > + Array of strings > + One of: > + - "nvidia,tegra194-tcu" > +- mbox-names: > + "rx" - Mailbox for receiving data from hardware UART > + "tx" - Mailbox for transmitting data to hardware UART > +- mboxes: Mailboxes corresponding to the mbox-names. > + > +This node is a mailbox consumer. See the following files for details of > +the mailbox subsystem, and the specifiers implemented by the relevant > +provider(s): > + > +- .../mailbox/mailbox.txt > +- .../mailbox/nvidia,tegra186-hsp.txt > + > +Example bindings: > +----------------- > + > +tcu: tcu { > + compatible = "nvidia,tegra194-tcu"; > + mboxes = <&hsp_top0 TEGRA_HSP_MBOX_TYPE_SM 0>, > + <&hsp_aon TEGRA_HSP_MBOX_TYPE_SM 1>; > + mbox-names = "rx", "tx"; > +}; > -- > 2.16.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt b/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt new file mode 100644 index 000000000000..86763bc5d74f --- /dev/null +++ b/Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt @@ -0,0 +1,35 @@ +NVIDIA Tegra Combined UART (TCU) + +The TCU is a system for sharing a hardware UART instance among multiple +systems withing the Tegra SoC. It is implemented through a mailbox- +based protocol where each "virtual UART" has a pair of mailboxes, one +for transmitting and one for receiving, that is used to communicate +with the hardware implementing the TCU. + +Required properties: +- name : Should be tcu +- compatible + Array of strings + One of: + - "nvidia,tegra194-tcu" +- mbox-names: + "rx" - Mailbox for receiving data from hardware UART + "tx" - Mailbox for transmitting data to hardware UART +- mboxes: Mailboxes corresponding to the mbox-names. + +This node is a mailbox consumer. See the following files for details of +the mailbox subsystem, and the specifiers implemented by the relevant +provider(s): + +- .../mailbox/mailbox.txt +- .../mailbox/nvidia,tegra186-hsp.txt + +Example bindings: +----------------- + +tcu: tcu { + compatible = "nvidia,tegra194-tcu"; + mboxes = <&hsp_top0 TEGRA_HSP_MBOX_TYPE_SM 0>, + <&hsp_aon TEGRA_HSP_MBOX_TYPE_SM 1>; + mbox-names = "rx", "tx"; +};
Add bindings for the Tegra Combined UART device used to talk to the UART console on Tegra194 systems. Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> --- .../bindings/serial/nvidia,tegra194-tcu.txt | 35 ++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/serial/nvidia,tegra194-tcu.txt