| Message ID | 1525749566-50769-4-git-send-email-ley.foon.tan@intel.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | drivers: Add reset ctrl to drivers | expand |
On 8 May 2018 at 13:19, Ley Foon Tan <ley.foon.tan@intel.com> wrote: > Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature, > so only print out a warning and do not fail if a reset property is not present. > > If a reset property is discovered, then use it to deassert, thus bringing the > IP out of reset. > > Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com> > --- > drivers/net/designware.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Mon, May 7, 2018 at 10:19 PM, Ley Foon Tan <ley.foon.tan@intel.com> wrote: > Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature, > so only print out a warning and do not fail if a reset property is not present. > > If a reset property is discovered, then use it to deassert, thus bringing the > IP out of reset. > > Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
On Wed, May 16, 2018 at 5:08 AM, Joe Hershberger <joe.hershberger@ni.com> wrote: > On Mon, May 7, 2018 at 10:19 PM, Ley Foon Tan <ley.foon.tan@intel.com> wrote: >> Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature, >> so only print out a warning and do not fail if a reset property is not present. >> >> If a reset property is discovered, then use it to deassert, thus bringing the >> IP out of reset. >> >> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com> > > Acked-by: Joe Hershberger <joe.hershberger@ni.com> Hi Joe Will you merge this patch to mainline? Regards Ley Foon
On Wed, May 23, 2018 at 9:22 PM, Ley Foon Tan <lftan.linux@gmail.com> wrote: > On Wed, May 16, 2018 at 5:08 AM, Joe Hershberger <joe.hershberger@ni.com> wrote: >> On Mon, May 7, 2018 at 10:19 PM, Ley Foon Tan <ley.foon.tan@intel.com> wrote: >>> Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature, >>> so only print out a warning and do not fail if a reset property is not present. >>> >>> If a reset property is discovered, then use it to deassert, thus bringing the >>> IP out of reset. >>> >>> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com> >> >> Acked-by: Joe Hershberger <joe.hershberger@ni.com> > > Hi Joe > > Will you merge this patch to mainline? OK... it was assigned to Tom in patchwork, but I moved it to me. -Joe
diff --git a/drivers/net/designware.c b/drivers/net/designware.c index cf12521..6797691 100644 --- a/drivers/net/designware.c +++ b/drivers/net/designware.c @@ -15,6 +15,7 @@ #include <miiphy.h> #include <malloc.h> #include <pci.h> +#include <reset.h> #include <linux/compiler.h> #include <linux/err.h> #include <linux/kernel.h> @@ -664,6 +665,7 @@ int designware_eth_probe(struct udevice *dev) u32 iobase = pdata->iobase; ulong ioaddr; int ret; + struct reset_ctl_bulk reset_bulk; #ifdef CONFIG_CLK int i, err, clock_nb; @@ -710,6 +712,12 @@ int designware_eth_probe(struct udevice *dev) } #endif + ret = reset_get_bulk(dev, &reset_bulk); + if (ret) + dev_warn(dev, "Can't get reset: %d\n", ret); + else + reset_deassert_bulk(&reset_bulk); + #ifdef CONFIG_DM_PCI /* * If we are on PCI bus, either directly attached to a PCI root port,
Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature, so only print out a warning and do not fail if a reset property is not present. If a reset property is discovered, then use it to deassert, thus bringing the IP out of reset. Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com> --- drivers/net/designware.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)