Patchwork vpc.c: Use get_option_parameter() does the search

login
register
mail settings
Submitter Lyu Mitnick
Date April 13, 2011, 9:30 a.m.
Message ID <1302687054-16675-1-git-send-email-mitnick.lyu@gmail.com>
Download mbox | patch
Permalink /patch/90973/
State New
Headers show

Comments

Lyu Mitnick - April 13, 2011, 9:30 a.m.
Use get_option_parameter() to instead of duplicating the loop, and use BDRV_SECTOR_SIZE to instead of 512

Signed-off-by: Mitnick Lyu <mitnick.lyu@gmail.com>
---
 block/vpc.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)
Kevin Wolf - April 13, 2011, 10:32 a.m.
Am 13.04.2011 11:30, schrieb Mitnick Lyu:
> Use get_option_parameter() to instead of duplicating the loop, and use BDRV_SECTOR_SIZE to instead of 512
> 
> Signed-off-by: Mitnick Lyu <mitnick.lyu@gmail.com>

Thanks, applied to the block branch.

Kevin

Patch

diff --git a/block/vpc.c b/block/vpc.c
index 7b025be..56865da 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -505,12 +505,8 @@  static int vpc_create(const char *filename, QEMUOptionParameter *options)
     int ret = -EIO;
 
     // Read out options
-    while (options && options->name) {
-        if (!strcmp(options->name, "size")) {
-            total_sectors = options->value.n / 512;
-        }
-        options++;
-    }
+    total_sectors = get_option_parameter(options, BLOCK_OPT_SIZE)->value.n /
+                    BDRV_SECTOR_SIZE;
 
     // Create the file
     fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0644);