ARM: dts: imx28-tx28: Fix alias DTC warnings

Message ID 1525693192-3579-1-git-send-email-festevam@gmail.com
State New
Headers show
Series
  • ARM: dts: imx28-tx28: Fix alias DTC warnings
Related show

Commit Message

Fabio Estevam May 7, 2018, 11:39 a.m.
From: Fabio Estevam <fabio.estevam@nxp.com>

Remove underscore from alias entries to fix the following DTC warnings
with W=1:

arch/arm/boot/dts/imx28-tx28.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

Cc: Lothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx28-tx28.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Shawn Guo May 15, 2018, 6:42 a.m. | #1
On Mon, May 07, 2018 at 08:39:52AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Remove underscore from alias entries to fix the following DTC warnings
> with W=1:
> 
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
> 
> Cc: Lothar Waßmann <LW@KARO-electronics.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  arch/arm/boot/dts/imx28-tx28.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index e4f19f9b..a5d6c97 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -56,11 +56,11 @@
>  		ds1339 = &ds1339;
>  		gpio5 = &gpio5;
>  		lcdif = &lcdif;
> -		lcdif_23bit_pins = &tx28_lcdif_23bit_pins;
> -		lcdif_24bit_pins = &lcdif_24bit_pins_a;
> -		reg_can_xcvr = &reg_can_xcvr;
> -		spi_gpio = &spi_gpio;
> -		spi_mxs = &ssp3;
> +		lcdif-23bit-pins = &tx28_lcdif_23bit_pins;
> +		lcdif-24bit-pins = &lcdif_24bit_pins_a;
> +		reg-can-xcvr = &reg_can_xcvr;
> +		spigpio = &spi_gpio;
> +		spi-mxs = &ssp3;
>  		stk5led = &user_led;
>  		usbotg = &usb0;
>  	};
> @@ -220,7 +220,7 @@
>  		linux,no-autorepeat;
>  	};
>  
> -	spi_gpio: spi-gpio {
> +	spi_gpio: spi {

Not sure why the node name needs to be changed here.

Shawn

>  		compatible = "spi-gpio";
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> -- 
> 2.7.4
>
Fabio Estevam May 15, 2018, 4:57 p.m. | #2
On Tue, May 15, 2018 at 3:42 AM, Shawn Guo <shawnguo@kernel.org> wrote:

>> -     spi_gpio: spi-gpio {
>> +     spi_gpio: spi {
>
> Not sure why the node name needs to be changed here.

Yes, this is a different fix and should be part of a different patch.

Patch

diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index e4f19f9b..a5d6c97 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -56,11 +56,11 @@ 
 		ds1339 = &ds1339;
 		gpio5 = &gpio5;
 		lcdif = &lcdif;
-		lcdif_23bit_pins = &tx28_lcdif_23bit_pins;
-		lcdif_24bit_pins = &lcdif_24bit_pins_a;
-		reg_can_xcvr = &reg_can_xcvr;
-		spi_gpio = &spi_gpio;
-		spi_mxs = &ssp3;
+		lcdif-23bit-pins = &tx28_lcdif_23bit_pins;
+		lcdif-24bit-pins = &lcdif_24bit_pins_a;
+		reg-can-xcvr = &reg_can_xcvr;
+		spigpio = &spi_gpio;
+		spi-mxs = &ssp3;
 		stk5led = &user_led;
 		usbotg = &usb0;
 	};
@@ -220,7 +220,7 @@ 
 		linux,no-autorepeat;
 	};
 
-	spi_gpio: spi-gpio {
+	spi_gpio: spi {
 		compatible = "spi-gpio";
 		#address-cells = <1>;
 		#size-cells = <0>;