Patchwork [U-Boot] MX51: mx51evk: Use struct to access SRSR register instead of offset

login
register
mail settings
Submitter Fabio Estevam
Date April 13, 2011, 3:02 a.m.
Message ID <1302663725-32748-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/90937/
State Superseded
Headers show

Comments

Fabio Estevam - April 13, 2011, 3:02 a.m.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx51evk/mx51evk.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
Jason Liu - April 13, 2011, 3:08 a.m.
2011/4/13 Fabio Estevam <festevam@gmail.com>:
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx51evk/mx51evk.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/board/freescale/mx51evk/mx51evk.c b/board/freescale/mx51evk/mx51evk.c
> index 02a765d..3f2217c 100644
> --- a/board/freescale/mx51evk/mx51evk.c
> +++ b/board/freescale/mx51evk/mx51evk.c
> @@ -431,6 +431,10 @@ int board_late_init(void)
>
>  int checkboard(void)
>  {
> +       u32 reset;
> +       struct src *src_regs = (struct src *)SRC_BASE_ADDR;
> +       reset = src_regs->srsr;

Would better to use __raw_readl(&src_regs->srsr) here.

> +
>        puts("Board: MX51EVK ");
>
>        switch (system_rev & 0xff) {
> @@ -452,7 +456,7 @@ int checkboard(void)
>                break;
>        }
>
> -       switch (__raw_readl(SRC_BASE_ADDR + 0x8)) {
> +       switch (reset) {
>        case 0x0001:
>                puts("POR");
>                break;
> --
> 1.6.0.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Sergei Shtylyov - April 13, 2011, 10:22 a.m.
Hello.

On 13-04-2011 7:02, Fabio Estevam wrote:

> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>
> ---
>   board/freescale/mx51evk/mx51evk.c |    6 +++++-
>   1 files changed, 5 insertions(+), 1 deletions(-)

> diff --git a/board/freescale/mx51evk/mx51evk.c b/board/freescale/mx51evk/mx51evk.c
> index 02a765d..3f2217c 100644
> --- a/board/freescale/mx51evk/mx51evk.c
> +++ b/board/freescale/mx51evk/mx51evk.c
> @@ -431,6 +431,10 @@ int board_late_init(void)
>
>   int checkboard(void)
>   {
> +	u32 reset;
> +	struct src *src_regs = (struct src *)SRC_BASE_ADDR;

    Should be an emoty line here\.

> +	reset = src_regs->srsr;

    Why not declare this variable later than 'src_regs' and just initialize it?

WBR, Sergei

Patch

diff --git a/board/freescale/mx51evk/mx51evk.c b/board/freescale/mx51evk/mx51evk.c
index 02a765d..3f2217c 100644
--- a/board/freescale/mx51evk/mx51evk.c
+++ b/board/freescale/mx51evk/mx51evk.c
@@ -431,6 +431,10 @@  int board_late_init(void)
 
 int checkboard(void)
 {
+	u32 reset;
+	struct src *src_regs = (struct src *)SRC_BASE_ADDR;
+	reset = src_regs->srsr;
+
 	puts("Board: MX51EVK ");
 
 	switch (system_rev & 0xff) {
@@ -452,7 +456,7 @@  int checkboard(void)
 		break;
 	}
 
-	switch (__raw_readl(SRC_BASE_ADDR + 0x8)) {
+	switch (reset) {
 	case 0x0001:
 		puts("POR");
 		break;