diff mbox series

[34/67] hw/ppc: add include directory headers

Message ID 1525376963-79623-35-git-send-email-mst@redhat.com
State New
Headers show
Series include path cleanup | expand

Commit Message

Michael S. Tsirkin May 3, 2018, 7:51 p.m. UTC
This way they are easier to find using standard rules.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/hw/ppc/e500-ccsr.h | 1 +
 include/hw/ppc/mac.h       | 1 +
 2 files changed, 2 insertions(+)
 create mode 100644 include/hw/ppc/e500-ccsr.h
 create mode 100644 include/hw/ppc/mac.h

Comments

David Gibson May 4, 2018, 12:15 a.m. UTC | #1
On Thu, May 03, 2018 at 10:51:12PM +0300, Michael S. Tsirkin wrote:
> This way they are easier to find using standard rules.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

I don't really understand what this is accomplishing.

> ---
>  include/hw/ppc/e500-ccsr.h | 1 +
>  include/hw/ppc/mac.h       | 1 +
>  2 files changed, 2 insertions(+)
>  create mode 100644 include/hw/ppc/e500-ccsr.h
>  create mode 100644 include/hw/ppc/mac.h
> 
> diff --git a/include/hw/ppc/e500-ccsr.h b/include/hw/ppc/e500-ccsr.h
> new file mode 100644
> index 0000000..08e4ba2
> --- /dev/null
> +++ b/include/hw/ppc/e500-ccsr.h
> @@ -0,0 +1 @@
> +#include_next "../hw/ppc/e500-ccsr.h"
> diff --git a/include/hw/ppc/mac.h b/include/hw/ppc/mac.h
> new file mode 100644
> index 0000000..e0f0b67
> --- /dev/null
> +++ b/include/hw/ppc/mac.h
> @@ -0,0 +1 @@
> +#include_next "../hw/ppc/mac.h"
Michael S. Tsirkin May 4, 2018, 2:39 a.m. UTC | #2
On Fri, May 04, 2018 at 10:15:56AM +1000, David Gibson wrote:
> On Thu, May 03, 2018 at 10:51:12PM +0300, Michael S. Tsirkin wrote:
> > This way they are easier to find using standard rules.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> I don't really understand what this is accomplishing.

Pls see the cover letter.

The specific headers are used outside their directory so ideally long
term either they should move to include or split or callers refactored.

It's up to maintainers to decide what to do, I do not want to make this
decision.

> > ---
> >  include/hw/ppc/e500-ccsr.h | 1 +
> >  include/hw/ppc/mac.h       | 1 +
> >  2 files changed, 2 insertions(+)
> >  create mode 100644 include/hw/ppc/e500-ccsr.h
> >  create mode 100644 include/hw/ppc/mac.h
> > 
> > diff --git a/include/hw/ppc/e500-ccsr.h b/include/hw/ppc/e500-ccsr.h
> > new file mode 100644
> > index 0000000..08e4ba2
> > --- /dev/null
> > +++ b/include/hw/ppc/e500-ccsr.h
> > @@ -0,0 +1 @@
> > +#include_next "../hw/ppc/e500-ccsr.h"
> > diff --git a/include/hw/ppc/mac.h b/include/hw/ppc/mac.h
> > new file mode 100644
> > index 0000000..e0f0b67
> > --- /dev/null
> > +++ b/include/hw/ppc/mac.h
> > @@ -0,0 +1 @@
> > +#include_next "../hw/ppc/mac.h"
> 
> -- 
> David Gibson			| I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
> 				| _way_ _around_!
> http://www.ozlabs.org/~dgibson
David Gibson May 4, 2018, 3:07 a.m. UTC | #3
On Fri, May 04, 2018 at 05:39:57AM +0300, Michael S. Tsirkin wrote:
> On Fri, May 04, 2018 at 10:15:56AM +1000, David Gibson wrote:
> > On Thu, May 03, 2018 at 10:51:12PM +0300, Michael S. Tsirkin wrote:
> > > This way they are easier to find using standard rules.
> > > 
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > 
> > I don't really understand what this is accomplishing.
> 
> Pls see the cover letter.

The cover letter that I wasn't CCed on, and won't appear in the git
history?  Ok.. I read that and I still don't really see how this
specific patch fits into the overall picture.

> The specific headers are used outside their directory so ideally long
> term either they should move to include or split or callers refactored.
> 
> It's up to maintainers to decide what to do, I do not want to make this
> decision.
> 
> > > ---
> > >  include/hw/ppc/e500-ccsr.h | 1 +
> > >  include/hw/ppc/mac.h       | 1 +
> > >  2 files changed, 2 insertions(+)
> > >  create mode 100644 include/hw/ppc/e500-ccsr.h
> > >  create mode 100644 include/hw/ppc/mac.h
> > > 
> > > diff --git a/include/hw/ppc/e500-ccsr.h b/include/hw/ppc/e500-ccsr.h
> > > new file mode 100644
> > > index 0000000..08e4ba2
> > > --- /dev/null
> > > +++ b/include/hw/ppc/e500-ccsr.h
> > > @@ -0,0 +1 @@
> > > +#include_next "../hw/ppc/e500-ccsr.h"
> > > diff --git a/include/hw/ppc/mac.h b/include/hw/ppc/mac.h
> > > new file mode 100644
> > > index 0000000..e0f0b67
> > > --- /dev/null
> > > +++ b/include/hw/ppc/mac.h
> > > @@ -0,0 +1 @@
> > > +#include_next "../hw/ppc/mac.h"
> > 
> 
>
diff mbox series

Patch

diff --git a/include/hw/ppc/e500-ccsr.h b/include/hw/ppc/e500-ccsr.h
new file mode 100644
index 0000000..08e4ba2
--- /dev/null
+++ b/include/hw/ppc/e500-ccsr.h
@@ -0,0 +1 @@ 
+#include_next "../hw/ppc/e500-ccsr.h"
diff --git a/include/hw/ppc/mac.h b/include/hw/ppc/mac.h
new file mode 100644
index 0000000..e0f0b67
--- /dev/null
+++ b/include/hw/ppc/mac.h
@@ -0,0 +1 @@ 
+#include_next "../hw/ppc/mac.h"