| Message ID | 1525376963-79623-22-git-send-email-mst@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | include path cleanup | expand |
On Thu, May 03, 2018 at 10:50:59PM +0300, Michael S. Tsirkin wrote: > When pulling in headers that are in the same directory as C file (as > opposed to one in include/), we should use its relative path, without a > directory. Directory based path works more or less by accident. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > trace/qmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote: > When pulling in headers that are in the same directory as C file (as > opposed to one in include/), we should use its relative path, without a > directory. Directory based path works more or less by accident. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Can this be squashed with your 6/67? Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > trace/qmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/trace/qmp.c b/trace/qmp.c > index 756086c..ea99b00 100644 > --- a/trace/qmp.c > +++ b/trace/qmp.c > @@ -10,7 +10,7 @@ > #include "qemu/osdep.h" > #include "qapi/error.h" > #include "qapi/qapi-commands-trace.h" > -#include "trace/control.h" > +#include "control.h" > > > static CPUState *get_cpu(bool has_vcpu, int vcpu, Error **errp) >
diff --git a/trace/qmp.c b/trace/qmp.c index 756086c..ea99b00 100644 --- a/trace/qmp.c +++ b/trace/qmp.c @@ -10,7 +10,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qapi/qapi-commands-trace.h" -#include "trace/control.h" +#include "control.h" static CPUState *get_cpu(bool has_vcpu, int vcpu, Error **errp)
When pulling in headers that are in the same directory as C file (as opposed to one in include/), we should use its relative path, without a directory. Directory based path works more or less by accident. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- trace/qmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)