Message ID | CAFXrp_cbD89wmzAf44aNjHfQS+ixvMUqMmxFxeLjLbvGDr3FFA@mail.gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | ltp-testsuite: add --with-open-posix-testsuite | expand |
Hi Ciro, > Ah, learned about get-developers now :-) Thanks for tip :) > ---------- Forwarded message ---------- > From: Ciro Santilli <ciro.santilli@gmail.com> > Date: Thu, May 3, 2018 at 5:03 PM > Subject: [PATCH] ltp-testsuite: add --with-open-posix-testsuite > To: buildroot@busybox.net > The issues mentioned on the removed comments were resolved, > tested in QEMU x86_64 and aarch64. Yes, I've been thinking about reenabling it again last week for the same reason :-). Thank you for your patch. > Signed-off-by: Ciro Santilli <ciro.santilli@gmail.com> > --- > This patch supposes that the removed comments imply that a default > --with-open-posix-testsuite > is desirable (and I confirm that it does not take unreasoble build > time or disk space), > and that there is no generic way to add autotools configs to packages: > https://stackoverflow.com/questions/44341188/how-to-pass-extra-custom-configure-autotools-options-to-a-buildroot-package > package/ltp-testsuite/ltp-testsuite.mk | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > diff --git a/package/ltp-testsuite/ltp-testsuite.mk > b/package/ltp-testsuite/ltp-testsuite.mk > index c47f587836..4584ca45da 100644 > --- a/package/ltp-testsuite/ltp-testsuite.mk > +++ b/package/ltp-testsuite/ltp-testsuite.mk > @@ -9,17 +9,8 @@ LTP_TESTSUITE_SOURCE = ltp-full-$(LTP_TESTSUITE_VERSION).tar.xz > LTP_TESTSUITE_SITE = > https://github.com/linux-test-project/ltp/releases/download/$(LTP_TESTSUITE_VERSION) > LTP_TESTSUITE_LICENSE = GPL-2.0, GPL-2.0+ > LTP_TESTSUITE_LICENSE_FILES = COPYING > - > -# Do not enable Open POSIX testsuite as it doesn't cross-compile > -# properly: t0 program is built for the host machine. Notice that due > -# to a bug, --without-open-posix-testsuite actually enables the test > -# suite. > -# See https://github.com/linux-test-project/ltp/issues/143 (invalid > -# autoconf test) and > -# https://github.com/linux-test-project/ltp/issues/144 (Open POSIX > -# testsuite not cross-compiling). > LTP_TESTSUITE_CONF_OPTS += \ > - --with-realtime-testsuite > + --with-realtime-testsuite --with-open-posix-testsuite > ifeq ($(BR2_LINUX_KERNEL),y) > LTP_TESTSUITE_DEPENDENCIES += linux Acked-by: Petr Vorel <petr.vorel@gmail.com> Kind regards, Petr
Hello Ciro, On Thu, 3 May 2018 17:03:16 +0100, Ciro Santilli wrote: > The issues mentioned on the removed comments were resolved, > tested in QEMU x86_64 and aarch64. > > Signed-off-by: Ciro Santilli <ciro.santilli@gmail.com> > --- > This patch supposes that the removed comments imply that a default > --with-open-posix-testsuite > is desirable (and I confirm that it does not take unreasoble build > time or disk space), > and that there is no generic way to add autotools configs to packages: > https://stackoverflow.com/questions/44341188/how-to-pass-extra-custom-configure-autotools-options-to-a-buildroot-package Thanks for this contribution. However, your patch was corrupted, so it would be nice to use "git send-email" next time to submit a patch. However, since the patch was simple, I fixed it up, and applied. Thanks again! Thomas
On Thu, May 3, 2018 at 8:55 PM, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > Hello Ciro, > > On Thu, 3 May 2018 17:03:16 +0100, Ciro Santilli wrote: >> The issues mentioned on the removed comments were resolved, >> tested in QEMU x86_64 and aarch64. >> >> Signed-off-by: Ciro Santilli <ciro.santilli@gmail.com> >> --- >> This patch supposes that the removed comments imply that a default >> --with-open-posix-testsuite >> is desirable (and I confirm that it does not take unreasoble build >> time or disk space), >> and that there is no generic way to add autotools configs to packages: >> https://stackoverflow.com/questions/44341188/how-to-pass-extra-custom-configure-autotools-options-to-a-buildroot-package > > Thanks for this contribution. However, your patch was corrupted, so it > would be nice to use "git send-email" next time to submit a patch. > Ah, sorry about that. git send-email didn't work on the network I was on, but it works on my home network with the exact same git configs. The problem is described at: https://stackoverflow.com/questions/28038662/unable-to-initialize-smtp-properly-using-git but none of the answers helped :-( I wonder if anyone has ever solved it. > However, since the patch was simple, I fixed it up, and applied. Thanks > again! > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > https://bootlin.com
On 03-05-18 18:03, Ciro Santilli wrote: > The issues mentioned on the removed comments were resolved, > tested in QEMU x86_64 and aarch64. Would be good to refer to the upstream commit that fixes it: ca9561c124408ed0f5ed92c9ac7e092de05b5aed. > Signed-off-by: Ciro Santilli <ciro.santilli@gmail.com> > --- > This patch supposes that the removed comments imply that a default > --with-open-posix-testsuite > is desirable (and I confirm that it does not take unreasoble build > time or disk space), Indeed, no reason not to enable it. Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout > and that there is no generic way to add autotools configs to packages: > https://stackoverflow.com/questions/44341188/how-to-pass-extra-custom-configure-autotools-options-to-a-buildroot-package > > package/ltp-testsuite/ltp-testsuite.mk | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/package/ltp-testsuite/ltp-testsuite.mk > b/package/ltp-testsuite/ltp-testsuite.mk > index c47f587836..4584ca45da 100644 > --- a/package/ltp-testsuite/ltp-testsuite.mk > +++ b/package/ltp-testsuite/ltp-testsuite.mk > @@ -9,17 +9,8 @@ LTP_TESTSUITE_SOURCE = ltp-full-$(LTP_TESTSUITE_VERSION).tar.xz > LTP_TESTSUITE_SITE = > https://github.com/linux-test-project/ltp/releases/download/$(LTP_TESTSUITE_VERSION) > LTP_TESTSUITE_LICENSE = GPL-2.0, GPL-2.0+ > LTP_TESTSUITE_LICENSE_FILES = COPYING > - > -# Do not enable Open POSIX testsuite as it doesn't cross-compile > -# properly: t0 program is built for the host machine. Notice that due > -# to a bug, --without-open-posix-testsuite actually enables the test > -# suite. > -# See https://github.com/linux-test-project/ltp/issues/143 (invalid > -# autoconf test) and > -# https://github.com/linux-test-project/ltp/issues/144 (Open POSIX > -# testsuite not cross-compiling). > LTP_TESTSUITE_CONF_OPTS += \ > - --with-realtime-testsuite > + --with-realtime-testsuite --with-open-posix-testsuite > > ifeq ($(BR2_LINUX_KERNEL),y) > LTP_TESTSUITE_DEPENDENCIES += linux >
diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk index c47f587836..4584ca45da 100644 --- a/package/ltp-testsuite/ltp-testsuite.mk +++ b/package/ltp-testsuite/ltp-testsuite.mk @@ -9,17 +9,8 @@ LTP_TESTSUITE_SOURCE = ltp-full-$(LTP_TESTSUITE_VERSION).tar.xz LTP_TESTSUITE_SITE = https://github.com/linux-test-project/ltp/releases/download/$(LTP_TESTSUITE_VERSION) LTP_TESTSUITE_LICENSE = GPL-2.0, GPL-2.0+ LTP_TESTSUITE_LICENSE_FILES = COPYING - -# Do not enable Open POSIX testsuite as it doesn't cross-compile -# properly: t0 program is built for the host machine. Notice that due -# to a bug, --without-open-posix-testsuite actually enables the test -# suite. -# See https://github.com/linux-test-project/ltp/issues/143 (invalid -# autoconf test) and -# https://github.com/linux-test-project/ltp/issues/144 (Open POSIX -# testsuite not cross-compiling). LTP_TESTSUITE_CONF_OPTS += \ - --with-realtime-testsuite + --with-realtime-testsuite --with-open-posix-testsuite ifeq ($(BR2_LINUX_KERNEL),y)
The issues mentioned on the removed comments were resolved, tested in QEMU x86_64 and aarch64. Signed-off-by: Ciro Santilli <ciro.santilli@gmail.com> --- This patch supposes that the removed comments imply that a default --with-open-posix-testsuite is desirable (and I confirm that it does not take unreasoble build time or disk space), and that there is no generic way to add autotools configs to packages: https://stackoverflow.com/questions/44341188/how-to-pass-extra-custom-configure-autotools-options-to-a-buildroot-package package/ltp-testsuite/ltp-testsuite.mk | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) LTP_TESTSUITE_DEPENDENCIES += linux