From patchwork Thu May 3 12:20:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Sahu X-Patchwork-Id: 908013 X-Patchwork-Delegate: miquel.raynal@bootlin.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PHNtL2fG"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="beEwrY/5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="PxwzvLrV"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40cDx22sJPz9s35 for ; Thu, 3 May 2018 22:29:42 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=GCVGAhOcfcJ2C8wMPYCObsPmD+WrJ/uO9y9qfgMsQXw=; b=PHNtL2fG6YrQUHfs/r+Ex9tGy2 h0tMTGvHIe2JGNedzg9hQ/+YTYx1Fz3NjBNCh7HZYNNFFBrEJgoiUsPF7IJlagRQhQ97rxu21dLHT 8Hf0gHMoEpb6SO6iGW4e8nuhH/TMGX/A2nC4BVk2fnHAp5p4WN27BW4XsO1XUHDS72LbGJLnEJFWE M/IxX08dKFWdKwi2K70gKyrAwyIEa5Db60Lv/y+1Aas9ReZA/OCjX853Q68WDqTkD0KzxJPK9WTlg cY6h4PB+6Hu7TGVx63Ytr4T+GNSs7ZQbXXYVkOS0/6BtZGZ9cvNS0GRK3y/rYBne0ahiSqvdY6qOZ jVfo4zQg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fEDMa-0003fE-7t; Thu, 03 May 2018 12:29:32 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fEDF4-0007q1-Gr for linux-mtd@lists.infradead.org; Thu, 03 May 2018 12:21:57 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C1B1560C67; Thu, 3 May 2018 12:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525350095; bh=1i13Ydf2+EnlWK/NOgofMJYzgzrk/ymUqAu5PrAV1Rs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=beEwrY/58+Yj38DWOYvsxoK5hSUjupb0cVBf8ZIGov68cuRZl2iEfXRheNlMjAWue hqZe10BSO6ADdvzsOIdp9vQ+bF+xrXmkU067K/qpXC2sPaqGJfni7wR7q9+swqrhJT mX4Guia1oFAxFFn/UfNq8KtOsL/wSpiAb04yDfL4= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from absahu-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: absahu@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id F377160591; Thu, 3 May 2018 12:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525350094; bh=1i13Ydf2+EnlWK/NOgofMJYzgzrk/ymUqAu5PrAV1Rs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PxwzvLrVvR/3MmLUu7fqeE1sP5RbHiloXABtgqytHr5EwXvRZAxrZJUSOL5uhBxUT Onyt/Hix6NWlXuND8dn/lQUcf2f5TGrqCJnYEdLP2xaGjCsqgUqJqrnNBl1d7VECYy f1DIwvq7L1PQ1MLSjut2LYLG4ZR0vNZTk9R0hGfc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F377160591 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=absahu@codeaurora.org From: Abhishek Sahu To: Boris Brezillon Subject: [PATCH v2 09/14] mtd: rawnand: qcom: modify write_oob to remove read codeword part Date: Thu, 3 May 2018 17:50:36 +0530 Message-Id: <1525350041-22995-10-git-send-email-absahu@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1525350041-22995-1-git-send-email-absahu@codeaurora.org> References: <1525350041-22995-1-git-send-email-absahu@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180503_052146_651041_DFA3D495 X-CRM114-Status: GOOD ( 18.96 ) X-Spam-Score: -2.4 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [198.145.29.96 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Archit Taneja , Richard Weinberger , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Vasut , Abhishek Sahu , linux-mtd@lists.infradead.org, Miquel Raynal , Andy Gross , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org QCOM NAND layout protect available OOB data bytes with ECC also so when ecc->write_oob (qcom_nandc_write_oob) is being called then it can't update just OOB bytes. Currently, it first reads the last codeword which includes old OOB bytes. Then it updates the old OOB bytes with new one and then again writes the codeword back. The reading codeword is unnecessary since all the other bytes should be 0xff only. This patch removes the read part and updates the oob bytes with all other data bytes as 0xff. Signed-off-by: Abhishek Sahu Acked-by: Miquel Raynal --- * Changes from v1: NEW CHANGE drivers/mtd/nand/raw/qcom_nandc.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c index 61d0e7d..f85d8ab 100644 --- a/drivers/mtd/nand/raw/qcom_nandc.c +++ b/drivers/mtd/nand/raw/qcom_nandc.c @@ -2067,10 +2067,9 @@ static int qcom_nandc_write_page_raw(struct mtd_info *mtd, * implements ecc->write_oob() * * the NAND controller cannot write only data or only oob within a codeword, - * since ecc is calculated for the combined codeword. we first copy the - * entire contents for the last codeword(data + oob), replace the old oob - * with the new one in chip->oob_poi, and then write the entire codeword. - * this read-copy-write operation results in a slight performance loss. + * since ecc is calculated for the combined codeword. So make all the data + * bytes as 0xff and update the oob from chip->oob_poi, and then write + * the entire codeword again. */ static int qcom_nandc_write_oob(struct mtd_info *mtd, struct nand_chip *chip, int page) @@ -2082,20 +2081,14 @@ static int qcom_nandc_write_oob(struct mtd_info *mtd, struct nand_chip *chip, int data_size, oob_size; int ret; - host->use_ecc = true; - - clear_bam_transaction(nandc); - ret = copy_last_cw(host, page); - if (ret) - return ret; - - clear_read_regs(nandc); clear_bam_transaction(nandc); /* calculate the data and oob size for the last codeword/step */ data_size = ecc->size - ((ecc->steps - 1) << 2); oob_size = mtd->oobavail; + host->use_ecc = true; + memset(nandc->data_buffer, 0xff, host->cw_data); /* override new oob content to last codeword */ mtd_ooblayout_get_databytes(mtd, nandc->data_buffer + data_size, oob, 0, mtd->oobavail);