diff mbox series

[1/2] dt-bindings: gpio-xilinx: Update no-init property

Message ID 1525338346-31684-1-git-send-email-shubhrajyoti.datta@gmail.com
State New
Headers show
Series [1/2] dt-bindings: gpio-xilinx: Update no-init property | expand

Commit Message

Shubhrajyoti Datta May 3, 2018, 9:05 a.m. UTC 
From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>

In some cases the user may not want to initialise the
gpios to default. Add a property to allow the same. This is specially
useful in case the PS is reset and PL is not.

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
---
 Documentation/devicetree/bindings/gpio/gpio-xilinx.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Linus Walleij May 16, 2018, 12:12 p.m. UTC | #1 
On Thu, May 3, 2018 at 11:05 AM,  <shubhrajyoti.datta@gmail.com> wrote:

> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> In some cases the user may not want to initialise the
> gpios to default. Add a property to allow the same. This is specially
> useful in case the PS is reset and PL is not.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
(...)
> @@ -25,6 +25,7 @@ Optional properties:
>  - xlnx,dout-default-2 : as above but the second channel
>  - xlnx,gpio2-width : as above but for the second channel
>  - xlnx,tri-default-2 : as above but for the second channel
> +- xlnx,no-init : No initialisation at probe

This doesn't seem very Xilinx-specific? It looks more like something
any GPIO driver would want to do.

So a no-init-hardware; in gpio.txt seems more appropriate,
if this is even needed, see comments on next patch.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/gpio-xilinx.txt b/Documentation/devicetree/bindings/gpio/gpio-xilinx.txt
index 63bf4be..3a09d9e 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-xilinx.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-xilinx.txt
@@ -25,6 +25,7 @@  Optional properties:
 - xlnx,dout-default-2 : as above but the second channel
 - xlnx,gpio2-width : as above but for the second channel
 - xlnx,tri-default-2 : as above but for the second channel
+- xlnx,no-init : No initialisation at probe
 
 
 Example: