diff mbox series

[3/4] qemu-options: Remove deprecated -no-kvm-irqchip

Message ID 1525281868-24747-4-git-send-email-thuth@redhat.com
State New
Headers show
Series Removal of deprecated -no-kvm* options | expand

Commit Message

Thomas Huth May 2, 2018, 5:24 p.m. UTC 
We've never documented this option in our qemu-doc, so unless the users
used qemu-kvm before, they never should never have been aware of this
option. It's been marked as deprecated in the source code since a long
time already, and officially marked as deprecated in the documentation
since QEMU v2.10, so it should be fine to remove this now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 qemu-doc.texi   | 5 -----
 qemu-options.hx | 3 ---
 vl.c            | 5 -----
 3 files changed, 13 deletions(-)

Comments

Markus Armbruster May 3, 2018, 7:08 a.m. UTC | #1 
Thomas Huth <thuth@redhat.com> writes:

> We've never documented this option in our qemu-doc, so unless the users
> used qemu-kvm before, they never should never have been aware of this
> option. It's been marked as deprecated in the source code since a long
> time already, and officially marked as deprecated in the documentation
> since QEMU v2.10, so it should be fine to remove this now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

With the commit message touched up like PATCH 4's:
Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff mbox series

Patch

diff --git a/qemu-doc.texi b/qemu-doc.texi
index dd39bac..f605557 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -2786,11 +2786,6 @@  which is the default.
 
 @section System emulator command line arguments
 
-@subsection -no-kvm-irqchip (since 1.3.0)
-
-The ``-no-kvm-irqchip'' argument is now a synonym for
-setting ``-machine kernel_irqchip=off''.
-
 @subsection -no-kvm (since 1.3.0)
 
 The ``-no-kvm'' argument is now a synonym for setting
diff --git a/qemu-options.hx b/qemu-options.hx
index 9c0d60d..870a363 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3917,9 +3917,6 @@  ETEXI
 HXCOMM Deprecated by -machine accel=tcg property
 DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
 
-HXCOMM Deprecated by -machine kernel_irqchip=on|off property
-DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
-
 DEF("msg", HAS_ARG, QEMU_OPTION_msg,
     "-msg timestamp[=on|off]\n"
     "                change the format of messages\n"
diff --git a/vl.c b/vl.c
index 24478b1..0d77a48 100644
--- a/vl.c
+++ b/vl.c
@@ -3185,11 +3185,6 @@  int main(int argc, char **argv, char **envp)
                 exit(1);
             }
             switch(popt->index) {
-            case QEMU_OPTION_no_kvm_irqchip: {
-                olist = qemu_find_opts("machine");
-                qemu_opts_parse_noisily(olist, "kernel_irqchip=off", false);
-                break;
-            }
             case QEMU_OPTION_cpu:
                 /* hw initialization will check this */
                 cpu_model = optarg;