| Message ID | 1525281868-24747-5-git-send-email-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Removal of deprecated -no-kvm* options | expand |
Thomas Huth <thuth@redhat.com> writes: > We've never documented this option in our qemu-doc, so unless the users > used qemu-kvm before, they never should never have been aware of this You're serious about "never", aren't you? ;-> > option. It's been marked as deprecated in the source code since a long s/since/for/ > time already, and officially marked as deprecated in the documentation > since QEMU v2.10, so it should be fine to remove this now. > > Signed-off-by: Thomas Huth <thuth@redhat.com> With the commit message touched up: Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff --git a/qemu-doc.texi b/qemu-doc.texi index f605557..1c61a6a 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -2786,11 +2786,6 @@ which is the default. @section System emulator command line arguments -@subsection -no-kvm (since 1.3.0) - -The ``-no-kvm'' argument is now a synonym for setting -``-machine accel=tcg''. - @subsection -vnc tls (since 2.5.0) The ``-vnc tls'' argument is now a synonym for setting diff --git a/qemu-options.hx b/qemu-options.hx index 870a363..d77a968 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3914,9 +3914,6 @@ STEXI Enable FIPS 140-2 compliance mode. ETEXI -HXCOMM Deprecated by -machine accel=tcg property -DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386) - DEF("msg", HAS_ARG, QEMU_OPTION_msg, "-msg timestamp[=on|off]\n" " change the format of messages\n" diff --git a/vl.c b/vl.c index 0d77a48..593b197 100644 --- a/vl.c +++ b/vl.c @@ -3732,10 +3732,6 @@ int main(int argc, char **argv, char **envp) exit(1); } break; - case QEMU_OPTION_no_kvm: - olist = qemu_find_opts("machine"); - qemu_opts_parse_noisily(olist, "accel=tcg", false); - break; case QEMU_OPTION_accel: accel_opts = qemu_opts_parse_noisily(qemu_find_opts("accel"), optarg, true);
We've never documented this option in our qemu-doc, so unless the users used qemu-kvm before, they never should never have been aware of this option. It's been marked as deprecated in the source code since a long time already, and officially marked as deprecated in the documentation since QEMU v2.10, so it should be fine to remove this now. Signed-off-by: Thomas Huth <thuth@redhat.com> --- qemu-doc.texi | 5 ----- qemu-options.hx | 3 --- vl.c | 4 ---- 3 files changed, 12 deletions(-)