diff mbox series

[1/1] libgsasl: add mandatory dependency on wchar

Message ID 20180502155857.2933-1-fontaine.fabrice@gmail.com
State Accepted
Commit 00d40a4f29eafaded4cc530ab688a74162f21fa4
Headers show
Series [1/1] libgsasl: add mandatory dependency on wchar | expand

Commit Message

Fabrice Fontaine May 2, 2018, 3:58 p.m. UTC
libgsasl needs wctomb, if not available it will define it to
rpl_wctomb. However, as there is no rpl_wctomb implementation, the .so
ends up with an undefined reference to wctomb.

This will cause linker errors for packages trying to use it such as
msmtp:
/home/peko/autobuild/instance-0/output/host/bin/../microblazeel-buildroot-linux-uclibc/sysroot/usr//lib/libgsasl.so:
undefined reference to `wctomb'

Fixes:
 - http://autobuild.buildroot.net/results/1bc7cb9a2dd1af746c78f3150528206b7256e40f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libgsasl/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Peter Korsgaard May 2, 2018, 7:34 p.m. UTC | #1
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > libgsasl needs wctomb, if not available it will define it to
 > rpl_wctomb. However, as there is no rpl_wctomb implementation, the .so
 > ends up with an undefined reference to wctomb.

 > This will cause linker errors for packages trying to use it such as
 > msmtp:
 > /home/peko/autobuild/instance-0/output/host/bin/../microblazeel-buildroot-linux-uclibc/sysroot/usr//lib/libgsasl.so:
 > undefined reference to `wctomb'

 > Fixes:
 >  - http://autobuild.buildroot.net/results/1bc7cb9a2dd1af746c78f3150528206b7256e40f

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed, thanks.
diff mbox series

Patch

diff --git a/package/libgsasl/Config.in b/package/libgsasl/Config.in
index 5181386272..228f882377 100644
--- a/package/libgsasl/Config.in
+++ b/package/libgsasl/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_LIBGSASL
 	bool "libgsasl"
+	depends on BR2_USE_WCHAR
 	help
 	  Simple Authentication and Security Layer framework Library.
 	  GNU SASL is an implementation of the Simple Authentication and
@@ -9,3 +10,6 @@  config BR2_PACKAGE_LIBGSASL
 	  against servers.
 
 	  http://www.gnu.org/software/gsasl
+
+comment "libgsasl needs a toolchain w/ wchar"
+	depends on !BR2_USE_WCHAR