Patchwork [U-Boot,V4,1/4] VCMA9: activate ARM relocation feature

login
register
mail settings
Submitter David Müller (ELSOFT AG)
Date April 12, 2011, 9:32 a.m.
Message ID <1302600759-28219-2-git-send-email-d.mueller@elsoft.ch>
Download mbox | patch
Permalink /patch/90757/
State Changes Requested
Headers show

Comments

David Müller (ELSOFT AG) - April 12, 2011, 9:32 a.m.
Signed-off-by: David Müller <d.mueller@elsoft.ch>

---
 include/configs/VCMA9.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
Wolfgang Denk - April 12, 2011, 10:30 a.m.
Dear =?UTF-8?q?David=20M=C3=BCller?=,

In message <1302600759-28219-2-git-send-email-d.mueller@elsoft.ch> you wrote:
> --===============0390427290==
> 
> Signed-off-by: David Müller <d.mueller@elsoft.ch>
> 
> ---
>  include/configs/VCMA9.h |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/VCMA9.h b/include/configs/VCMA9.h
> index ebe9e42..b723908 100644
> --- a/include/configs/VCMA9.h
> +++ b/include/configs/VCMA9.h
> @@ -247,4 +247,10 @@
>  
>  #define MULTI_PURPOSE_SOCKET_ADDR 0x08000000
>  
> +/* additions for new relocation code, must added to all boards */

I don't see much sense in such a comment. "New relocation code" is not
generally meaningful, and "must be added" is not only missing a "be"
but also redundant as you just added the code.

Best regards,

Wolfgang Denk
Wolfgang Denk - April 12, 2011, 10:32 a.m.
Dear =?UTF-8?q?David=20M=C3=BCller?=,

In message <1302600759-28219-2-git-send-email-d.mueller@elsoft.ch> you wrote:
> 
> Signed-off-by: David Müller <d.mueller@elsoft.ch>

Actually the Subject: is wrong.  No part in this patch "activates"
anything - you just add some missing definitions to fix build
problems.

Best regards,

Wolfgang Denk

Patch

diff --git a/include/configs/VCMA9.h b/include/configs/VCMA9.h
index ebe9e42..b723908 100644
--- a/include/configs/VCMA9.h
+++ b/include/configs/VCMA9.h
@@ -247,4 +247,10 @@ 
 
 #define MULTI_PURPOSE_SOCKET_ADDR 0x08000000
 
+/* additions for new relocation code, must added to all boards */
+#define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+#define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x1000 - \
+					GENERATED_GBL_DATA_SIZE)
+
+
 #endif	/* __CONFIG_H */