| Message ID | 20180430032736.2862-1-mpe@ellerman.id.au (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 53da14d0833a663cb98ef111ed91c575f2da9236 |
| Headers | show |
| Series | powerpc: Make it clearer that systbl check errors are errors | expand |
On Mon, 2018-04-30 at 03:27:36 UTC, Michael Ellerman wrote: > If the systbl_chk.sh checks fail we print a message, but with no > indication that it's an error. That makes it hard to find in build > logs with eg. grep. > > So prefix any output with "Error:". > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Applied to powerpc next. https://git.kernel.org/powerpc/c/53da14d0833a663cb98ef111ed91c5 cheers
diff --git a/arch/powerpc/kernel/systbl_chk.sh b/arch/powerpc/kernel/systbl_chk.sh index 31b6e7c358ca..f2e356c2a345 100644 --- a/arch/powerpc/kernel/systbl_chk.sh +++ b/arch/powerpc/kernel/systbl_chk.sh @@ -16,7 +16,7 @@ awk 'BEGIN { num = -1; } # Ignore the beginning of the file /^START_TABLE/ { num = 0; next; } /^END_TABLE/ { if (num != $2) { - printf "NR_syscalls (%s) is not one more than the last syscall (%s)\n", + printf "Error: NR_syscalls (%s) is not one more than the last syscall (%s)\n", $2, num - 1; exit(1); } @@ -25,7 +25,7 @@ awk 'BEGIN { num = -1; } # Ignore the beginning of the file { if (num == -1) next; if (($1 != -1) && ($1 != num)) { - printf "Syscall %s out of order (expected %s)\n", + printf "Error: Syscall %s out of order (expected %s)\n", $1, num; exit(1); };
If the systbl_chk.sh checks fail we print a message, but with no indication that it's an error. That makes it hard to find in build logs with eg. grep. So prefix any output with "Error:". Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> --- arch/powerpc/kernel/systbl_chk.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)