From patchwork Mon Apr 11 19:24:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Basile Starynkevitch X-Patchwork-Id: 90636 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id BA5FCB6F15 for ; Tue, 12 Apr 2011 05:25:39 +1000 (EST) Received: (qmail 5283 invoked by alias); 11 Apr 2011 19:25:38 -0000 Received: (qmail 5273 invoked by uid 22791); 11 Apr 2011 19:25:37 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from smtp-101-monday.noc.nerim.net (HELO mallaury.nerim.net) (62.4.17.101) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Apr 2011 19:25:32 +0000 Received: from hector.lesours (ours.starynkevitch.net [213.41.244.95]) by mallaury.nerim.net (Postfix) with ESMTPS id C456C153411; Mon, 11 Apr 2011 21:25:30 +0200 (CEST) Received: from glinka.lesours ([192.168.0.1]) by hector.lesours with smtp (Exim 4.75) (envelope-from ) id 1Q9Mjp-0004xH-PK; Mon, 11 Apr 2011 21:25:29 +0200 Date: Mon, 11 Apr 2011 21:24:21 +0200 From: Basile Starynkevitch To: dnovillo@google.com Cc: gcc-patches@gcc.gnu.org Subject: Ping Patch: add {tree, gimple}-pretty-print.h & realmpfr.h to PLUGIN_HEADERS Message-Id: <20110411212421.e7c55588.basile@starynkevitch.net> In-Reply-To: <20110407214344.5a3afcb3.basile@starynkevitch.net> References: <20110407214118.2b121fe9.basile@starynkevitch.net> <20110407214344.5a3afcb3.basile@starynkevitch.net> Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Thu, 7 Apr 2011 21:43:44 +0200 Basile Starynkevitch wrote: > > The following tiny patch add some files to PLUGIN_HEADERS. ###### gcc/ChangeLog entry 2011-04-11 Basile Starynkevitch * Makefile.in (PLUGIN_HEADERS): Add gimple-pretty-print.h tree-pretty-print.h & realmpfr.h. ###### > Some more explanations about why I feel these files are badly needed > for plugins (not only for MELT as a plugin, but for other plugins). > > Pretty printing routines are very useful to help understand, debug, and > dump any additional passes, so plugin providing passes working on > Gimple or Tree need the gimple-pretty-print.h & tree-pretty-print.h, > since to call dumping or debug routines like debug_c_tree or > print_declaration or dump_gimple_stmt you need to include these files. > Please consider that people coding plugins know Gimple & Tree much > less than GCC top level experts, and they are much more likely to > need debug or dumping routines! > > The realmpfr.h file is needed to operate on tree or gimple containing > real constants. For instance, a plugin to find all occurrences (in > Gimple) of 3.14159 need it, or also a plugin which constant-fold the > calls to which are not already constant folded in GCC, or a > plugin which constant-fold calls to some other (but less standard) > numerical library. Ok for trunk? Index: gcc/Makefile.in =================================================================== --- gcc/Makefile.in (revision 172124) +++ gcc/Makefile.in (working copy) @@ -4534,6 +4534,7 @@ $(EXCEPT_H) tree-ssa-sccvn.h real.h output.h $(IPA_UTILS_H) \ $(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \ cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \ + gimple-pretty-print.h tree-pretty-print.h realmpfr.h \ $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h # generate the 'build fragment' b-header-vars