Patchwork cfi_cmdset_0002.c: Add CFI 1.5 support for S29GL-S

login
register
mail settings
Submitter Hoyler, Gernot
Date April 11, 2011, 1:53 p.m.
Message ID <201104111553.35457.Gernot.Hoyler@spansion.com>
Download mbox | patch
Permalink /patch/90605/
State Accepted
Commit c9ddab25d1b62baead4b0c5de562f1fce026dcfd
Headers show

Comments

Hoyler, Gernot - April 11, 2011, 1:53 p.m.
This patch adds CFI 1.5 support for the new Spansion S29GL-S device family.
For details, see the data sheet on the Spansion web site: 
http://www.spansion.com/Support/Datasheets/S29GL_128S_01GS_00_02_e.pdf

Signed-off-by: Gernot Hoyler <Gernot.Hoyler@spansion.com>
---
 drivers/mtd/chips/cfi_cmdset_0002.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Guillaume LECERF - April 11, 2011, 2:36 p.m.
2011/4/11 Gernot Hoyler <Gernot.Hoyler@spansion.com>:
> This patch adds CFI 1.5 support for the new Spansion S29GL-S device family.
> For details, see the data sheet on the Spansion web site:
> http://www.spansion.com/Support/Datasheets/S29GL_128S_01GS_00_02_e.pdf
>
> Signed-off-by: Gernot Hoyler <Gernot.Hoyler@spansion.com>

Acked-by: Guillaume LECERF <glecerf@gmail.com>
Artem Bityutskiy - April 13, 2011, 4:07 a.m.
On Mon, 2011-04-11 at 15:53 +0200, Gernot Hoyler wrote:
> This patch adds CFI 1.5 support for the new Spansion S29GL-S device family.
> For details, see the data sheet on the Spansion web site: 
> http://www.spansion.com/Support/Datasheets/S29GL_128S_01GS_00_02_e.pdf
> 
> Signed-off-by: Gernot Hoyler <Gernot.Hoyler@spansion.com>

Pushed to l2-mtd-2.6.git, thanks.
Guillaume LECERF - April 13, 2011, 9:24 a.m.
2011/4/13 Artem Bityutskiy <dedekind1@gmail.com>:
> Pushed to l2-mtd-2.6.git, thanks.

Where ?
Can't find it on http://git.infradead.org/users/dedekind/l2-mtd-2.6.git ...
Artem Bityutskiy - April 13, 2011, 10:06 a.m.
On Wed, 2011-04-13 at 11:24 +0200, Guillaume LECERF wrote:
> 2011/4/13 Artem Bityutskiy <dedekind1@gmail.com>:
> > Pushed to l2-mtd-2.6.git, thanks.
> 
> Where ?
> Can't find it on http://git.infradead.org/users/dedekind/l2-mtd-2.6.git ...

Sorry, it is there now.

Patch

diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index f9a5331..b216510 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -462,13 +462,14 @@  struct mtd_info *cfi_cmdset_0002(struct map_info *map, int primary)
 			cfi_fixup_major_minor(cfi, extp);
 
 			/*
-			 * Valid primary extension versions are: 1.0, 1.1, 1.2, 1.3, 1.4
+			 * Valid primary extension versions are: 1.0, 1.1, 1.2, 1.3, 1.4, 1.5
 			 * see: http://cs.ozerki.net/zap/pub/axim-x5/docs/cfi_r20.pdf, page 19 
 			 *      http://www.spansion.com/Support/AppNotes/cfi_100_20011201.pdf
 			 *      http://www.spansion.com/Support/Datasheets/s29ws-p_00_a12_e.pdf
+			 *      http://www.spansion.com/Support/Datasheets/S29GL_128S_01GS_00_02_e.pdf
 			 */
 			if (extp->MajorVersion != '1' ||
-			    (extp->MajorVersion == '1' && (extp->MinorVersion < '0' || extp->MinorVersion > '4'))) {
+			    (extp->MajorVersion == '1' && (extp->MinorVersion < '0' || extp->MinorVersion > '5'))) {
 				printk(KERN_ERR "  Unknown Amd/Fujitsu Extended Query "
 				       "version %c.%c (%#02x/%#02x).\n",
 				       extp->MajorVersion, extp->MinorVersion,