| Message ID | 1302513406-3758-3-git-send-email-peppe.cavallaro@st.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com> Date: Mon, 11 Apr 2011 11:16:46 +0200 > On some old MAC chips without COE sometime the > Transmit Underflow error is issued. > > The driver aborted all the transmission process > and initialized it from scratch. > This breaks the network activity as raised by Nachiketa > on a SPEAr board. > > The patch is to fix this rare underflow event. > The driver will only clear the interrupt and the Tx > DMA will go out the Suspend state as soon as the > descriptor is fetched again. > The driver will continue to bump-up the DMA FIFO threshold > that, indeed, helped somebody to prevent this kind of error > in the past as well. > > Reported-by: Nachiketa Prachanda <nprachanda@ncomputing.com> > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/stmmac/stmmac_main.c b/drivers/net/stmmac/stmmac_main.c index 442a7ca..ba9daec 100644 --- a/drivers/net/stmmac/stmmac_main.c +++ b/drivers/net/stmmac/stmmac_main.c @@ -749,7 +749,6 @@ static void stmmac_dma_interrupt(struct stmmac_priv *priv) priv->hw->dma->dma_mode(priv->ioaddr, tc, SF_DMA_MODE); priv->xstats.threshold = tc; } - stmmac_tx_err(priv); } else if (unlikely(status == tx_hard_error)) stmmac_tx_err(priv); }
On some old MAC chips without COE sometime the Transmit Underflow error is issued. The driver aborted all the transmission process and initialized it from scratch. This breaks the network activity as raised by Nachiketa on a SPEAr board. The patch is to fix this rare underflow event. The driver will only clear the interrupt and the Tx DMA will go out the Suspend state as soon as the descriptor is fetched again. The driver will continue to bump-up the DMA FIFO threshold that, indeed, helped somebody to prevent this kind of error in the past as well. Reported-by: Nachiketa Prachanda <nprachanda@ncomputing.com> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> --- drivers/net/stmmac/stmmac_main.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)