diff mbox series

[SRU,Bionic,1/1] UBUNTU: Packaging: Depends on linux-base that provides the necessary tools

Message ID 20180426180910.13372-2-cascardo@canonical.com
State New
Headers show
Series [SRU,Bionic,1/1] UBUNTU: Packaging: Depends on linux-base that provides the necessary tools | expand

Commit Message

Thadeu Lima de Souza Cascardo April 26, 2018, 6:09 p.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1767133

We Depends on linux-base because of linux-update-symlinks and
linux-check-removal. Those have been introduced in a version later than
4.0ubuntu1, which shipped on Xenial.

The unversioned Depends makes some upgrades to Bionic and installations of
linux-hwe-edge to break because those tools are not found during the configure
phase.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
---
 debian.master/control.d/flavour-control.stub | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Seth Forshee April 26, 2018, 7:02 p.m. UTC | #1
On Thu, Apr 26, 2018 at 03:09:10PM -0300, Thadeu Lima de Souza Cascardo wrote:
> BugLink: http://bugs.launchpad.net/bugs/1767133
> 
> We Depends on linux-base because of linux-update-symlinks and
> linux-check-removal. Those have been introduced in a version later than
> 4.0ubuntu1, which shipped on Xenial.
> 
> The unversioned Depends makes some upgrades to Bionic and installations of
> linux-hwe-edge to break because those tools are not found during the configure
> phase.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

Acked-by: Seth Forshee <seth.forshee@canonical.com>
Andy Whitcroft April 30, 2018, 10:03 a.m. UTC | #2
On Thu, Apr 26, 2018 at 03:09:10PM -0300, Thadeu Lima de Souza Cascardo wrote:
> BugLink: http://bugs.launchpad.net/bugs/1767133
> 
> We Depends on linux-base because of linux-update-symlinks and
> linux-check-removal. Those have been introduced in a version later than
> 4.0ubuntu1, which shipped on Xenial.
> 
> The unversioned Depends makes some upgrades to Bionic and installations of
> linux-hwe-edge to break because those tools are not found during the configure
> phase.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
> ---
>  debian.master/control.d/flavour-control.stub | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debian.master/control.d/flavour-control.stub b/debian.master/control.d/flavour-control.stub
> index 835a859aa9bc..00a4b03bdc33 100644
> --- a/debian.master/control.d/flavour-control.stub
> +++ b/debian.master/control.d/flavour-control.stub
> @@ -27,7 +27,7 @@ Architecture: ARCH
>  Section: kernel
>  Priority: optional
>  Provides: linux-image, fuse-module, aufs-dkms, =PROVIDES=${linux:rprovides}
> -Depends: ${misc:Depends}, ${shlibs:Depends}, kmod, linux-base, linux-modules-PKGVER-ABINUM-FLAVOUR
> +Depends: ${misc:Depends}, ${shlibs:Depends}, kmod, linux-base (>= 4.5ubuntu1~16.04.1), linux-modules-PKGVER-ABINUM-FLAVOUR
>  Recommends: BOOTLOADER, initramfs-tools | linux-initramfs-tool
>  Breaks: flash-kernel (<< 3.90ubuntu2) [arm64 armhf]
>  Conflicts: linux-image=SIGN-PEER-PKG=-PKGVER-ABINUM-FLAVOUR
> -- 
> 2.17.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

I guess that makes sense, I am supprised we could get into this
situation, but it seems technically correct.

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw
Thadeu Lima de Souza Cascardo April 30, 2018, 1:16 p.m. UTC | #3
Applied to bionic master-next branch.

Thanks.
Cascardo.

Applied-to: bionic/master-next
diff mbox series

Patch

diff --git a/debian.master/control.d/flavour-control.stub b/debian.master/control.d/flavour-control.stub
index 835a859aa9bc..00a4b03bdc33 100644
--- a/debian.master/control.d/flavour-control.stub
+++ b/debian.master/control.d/flavour-control.stub
@@ -27,7 +27,7 @@  Architecture: ARCH
 Section: kernel
 Priority: optional
 Provides: linux-image, fuse-module, aufs-dkms, =PROVIDES=${linux:rprovides}
-Depends: ${misc:Depends}, ${shlibs:Depends}, kmod, linux-base, linux-modules-PKGVER-ABINUM-FLAVOUR
+Depends: ${misc:Depends}, ${shlibs:Depends}, kmod, linux-base (>= 4.5ubuntu1~16.04.1), linux-modules-PKGVER-ABINUM-FLAVOUR
 Recommends: BOOTLOADER, initramfs-tools | linux-initramfs-tool
 Breaks: flash-kernel (<< 3.90ubuntu2) [arm64 armhf]
 Conflicts: linux-image=SIGN-PEER-PKG=-PKGVER-ABINUM-FLAVOUR