| Message ID | 20180426030705.6632-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] bridge: use hlist_entry_safe | expand |
On 26/04/18 06:07, YueHaibing wrote: > Use hlist_entry_safe() instead of open-coding it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > net/bridge/br_forward.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c > index b4eed11..7a7fd67 100644 > --- a/net/bridge/br_forward.c > +++ b/net/bridge/br_forward.c > @@ -274,8 +274,7 @@ void br_multicast_flood(struct net_bridge_mdb_entry *mdst, > struct net_bridge_port *port, *lport, *rport; > > lport = p ? p->port : NULL; > - rport = rp ? hlist_entry(rp, struct net_bridge_port, rlist) : > - NULL; > + rport = hlist_entry_safe(rp, struct net_bridge_port, rlist); > > if ((unsigned long)lport > (unsigned long)rport) { > port = lport; > Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
On Thu, 26 Apr 2018 11:07:05 +0800 YueHaibing <yuehaibing@huawei.com> wrote: > Use hlist_entry_safe() instead of open-coding it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > net/bridge/br_forward.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c > index b4eed11..7a7fd67 100644 > --- a/net/bridge/br_forward.c > +++ b/net/bridge/br_forward.c > @@ -274,8 +274,7 @@ void br_multicast_flood(struct net_bridge_mdb_entry *mdst, > struct net_bridge_port *port, *lport, *rport; > > lport = p ? p->port : NULL; > - rport = rp ? hlist_entry(rp, struct net_bridge_port, rlist) : > - NULL; > + rport = hlist_entry_safe(rp, struct net_bridge_port, rlist); > > if ((unsigned long)lport > (unsigned long)rport) { > port = lport; Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
From: YueHaibing <yuehaibing@huawei.com> Date: Thu, 26 Apr 2018 11:07:05 +0800 > Use hlist_entry_safe() instead of open-coding it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied, thanks.
diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c index b4eed11..7a7fd67 100644 --- a/net/bridge/br_forward.c +++ b/net/bridge/br_forward.c @@ -274,8 +274,7 @@ void br_multicast_flood(struct net_bridge_mdb_entry *mdst, struct net_bridge_port *port, *lport, *rport; lport = p ? p->port : NULL; - rport = rp ? hlist_entry(rp, struct net_bridge_port, rlist) : - NULL; + rport = hlist_entry_safe(rp, struct net_bridge_port, rlist); if ((unsigned long)lport > (unsigned long)rport) { port = lport;
Use hlist_entry_safe() instead of open-coding it. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- net/bridge/br_forward.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)