[4/5] cifs: smbd: depend on INFINIBAND_ADDR_TRANS

Message ID 20180425223412.207127-1-gthelen@google.com
State New
Headers show
Series
  • Untitled series #40998
Related show

Commit Message

Greg Thelen April 25, 2018, 10:34 p.m.
CIFS_SMB_DIRECT code depends on INFINIBAND_ADDR_TRANS provided symbols.
So declare the kconfig dependency.  This is necessary to allow for
enabling INFINIBAND without INFINIBAND_ADDR_TRANS.

Signed-off-by: Greg Thelen <gthelen@google.com>
Cc: Tarick Bedeir <tarick@google.com>
---
 fs/cifs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Long Li April 26, 2018, 1:14 a.m. | #1
> Subject: [PATCH 4/5] cifs: smbd: depend on INFINIBAND_ADDR_TRANS
> 
> CIFS_SMB_DIRECT code depends on INFINIBAND_ADDR_TRANS provided
> symbols.
> So declare the kconfig dependency.  This is necessary to allow for enabling
> INFINIBAND without INFINIBAND_ADDR_TRANS.
> 
> Signed-off-by: Greg Thelen <gthelen@google.com>
> Cc: Tarick Bedeir <tarick@google.com>

Reviewed-by: Long Li <longli@microsoft.com>

> ---
>  fs/cifs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index
> 741749a98614..5f132d59dfc2 100644
> --- a/fs/cifs/Kconfig
> +++ b/fs/cifs/Kconfig
> @@ -197,7 +197,7 @@ config CIFS_SMB311
> 
>  config CIFS_SMB_DIRECT
>  	bool "SMB Direct support (Experimental)"
> -	depends on CIFS=m && INFINIBAND || CIFS=y && INFINIBAND=y
> +	depends on CIFS=m && INFINIBAND && INFINIBAND_ADDR_TRANS
> || CIFS=y &&
> +INFINIBAND=y && INFINIBAND_ADDR_TRANS=y
>  	help
>  	  Enables SMB Direct experimental support for SMB 3.0, 3.02 and 3.1.1.
>  	  SMB Direct allows transferring SMB packets over RDMA. If unsure,
> --
> 2.17.0.441.gb46fe60e1d-goog
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the
> body of a message to majordomo@vger.kernel.org More majordomo info at
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.ke
> rnel.org%2Fmajordomo-
> info.html&data=02%7C01%7Clongli%40microsoft.com%7C680883705136432b
> 280b08d5aafcb355%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63
> 6602924686676279&sdata=cn1DPTCOpL2%2BBa62wGlUp2dEe8BAzFVPxhfRxf
> 2N1Ek%3D&reserved=0
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
index 741749a98614..5f132d59dfc2 100644
--- a/fs/cifs/Kconfig
+++ b/fs/cifs/Kconfig
@@ -197,7 +197,7 @@  config CIFS_SMB311
 
 config CIFS_SMB_DIRECT
 	bool "SMB Direct support (Experimental)"
-	depends on CIFS=m && INFINIBAND || CIFS=y && INFINIBAND=y
+	depends on CIFS=m && INFINIBAND && INFINIBAND_ADDR_TRANS || CIFS=y && INFINIBAND=y && INFINIBAND_ADDR_TRANS=y
 	help
 	  Enables SMB Direct experimental support for SMB 3.0, 3.02 and 3.1.1.
 	  SMB Direct allows transferring SMB packets over RDMA. If unsure,