| Submitter | Alexander Duyck |
|---|---|
| Date | April 8, 2011, 10:12 p.m. |
| Message ID | <20110408221234.26893.58812.stgit@gitlad.jf.intel.com> |
| Download | mbox | patch |
| Permalink | /patch/90434/ |
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
Comments
On Fri, 2011-04-08 at 15:12 -0700, Alexander Duyck wrote: > The current ethtool manpage is not displaying tables. After trying to pass > the manpage through tbl I repeatedly saw the error: > tbl:ethtool.8.in:707: unrecognised format `x' > tbl:ethtool.8.in:707: giving up on this table > > By dropping the 'x' the errors went away and when I built the manpage the > tables reappeared so I am assuming this is the correct approach. [...] I think this must depend somewhat on the version of tbl. I must admit I haven't yet tested with a range of versions. In groff 1.20.1, the 'x' column flag requested an 'expanded' column which will be as wide as possible (after allowing for the other column contents) with its contents word-wrapped if necessary. Without this flag, tbl wraps some columns poorly and complains about some tables being too wide (though I don't think they are). Clearly that is less bad than having it discard the tables altogether, so I will apply this. Ben.
Patch
diff --git a/ethtool.8.in b/ethtool.8.in index ed24d4c..714486e 100644 --- a/ethtool.8.in +++ b/ethtool.8.in @@ -540,7 +540,7 @@ names the type of message to enable or disable; \fIN\fR specifies the new flags numerically. The defined type names and numbers are: .TS nokeep; -lB l lx. +lB l l. drv 0x0001 General driver status probe 0x0002 Hardware probing link 0x0004 Link state @@ -569,7 +569,7 @@ Retrieves the receive network flow classification configurations. Retrieves the hash options for the specified network traffic type. .TS nokeep; -lB lx. +lB l. tcp4 TCP over IPv4 udp4 UDP over IPv4 ah4 IPSEC AH/ESP over IPv4 @@ -587,7 +587,7 @@ Configures the receive network flow classification. Configures the hash options for the specified network traffic type. .TS nokeep; -lB lx. +lB l. m Hash on the Layer 2 destination address of the rx packet. v Hash on the VLAN tag of the rx packet. t Hash on the Layer 3 protocol field of the rx packet. @@ -637,7 +637,7 @@ Configure Rx ntuple filters and actions .B flow\-type tcp4|udp4|sctp4|ether .TS nokeep; -lB lx. +lB l. tcp4 TCP over IPv4 udp4 UDP over IPv4 sctp4 SCTP over IPv4 @@ -704,7 +704,7 @@ Specify a mask for the user-specific data. Specifies the Rx queue to send packets to, or some other action. .TS nokeep; -lB lx. +lB l. -2 Clear the filter -1 Drop the matched flow 0 or higher Rx queue to route the flow
The current ethtool manpage is not displaying tables. After trying to pass the manpage through tbl I repeatedly saw the error: tbl:ethtool.8.in:707: unrecognised format `x' tbl:ethtool.8.in:707: giving up on this table By dropping the 'x' the errors went away and when I built the manpage the tables reappeared so I am assuming this is the correct approach. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> --- ethtool.8.in | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html