Message ID | 20180425112707.16392-1-yuehaibing@huawei.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 589b1f7e4b0db4c31cef3b55f7514857bfc4b093 |
Headers | show |
Series | powerpc/xics: add missing of_node_put() in error path | expand |
On Wed, 2018-04-25 at 11:27:07 UTC, YueHaibing wrote: > The device node obtained with of_find_compatible_node() should be > released by calling of_node_put(). But it was not released when > of_get_property() failed. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/589b1f7e4b0db4c31cef3b55f75148 cheers
diff --git a/arch/powerpc/sysdev/xics/xics-common.c b/arch/powerpc/sysdev/xics/xics-common.c index 77e864d..e54a9e6 100644 --- a/arch/powerpc/sysdev/xics/xics-common.c +++ b/arch/powerpc/sysdev/xics/xics-common.c @@ -448,7 +448,10 @@ static void __init xics_get_server_size(void) return; isize = of_get_property(np, "ibm,interrupt-server#-size", NULL); if (!isize) + { + of_node_put(np); return; + } xics_interrupt_server_size = be32_to_cpu(*isize); of_node_put(np); }
The device node obtained with of_find_compatible_node() should be released by calling of_node_put(). But it was not released when of_get_property() failed. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- arch/powerpc/sysdev/xics/xics-common.c | 3 +++ 1 file changed, 3 insertions(+)