Patchwork [4/6] fs-tests: integck: remove unnecessary check

mail settings
Submitter Artem Bityutskiy
Date April 8, 2011, 3:16 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/90382/
State Accepted
Commit e50bbb11fa14ef3587a0ab9f6af02749bb31dda8
Headers show


Artem Bityutskiy - April 8, 2011, 3:16 p.m.
From: Artem Bityutskiy <>

The 'link_new()' function has only one user, and the user checks
that the third 'file' argument is non NULL, so remove this check
from 'link_new()'. Let's be consistent and assume the 3rd argument
is never NULL, just like the first and the second ones.

This is just a minor improvement.

Signed-off-by: Artem Bityutskiy <>
 tests/fs-tests/integrity/integck.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)


diff --git a/tests/fs-tests/integrity/integck.c b/tests/fs-tests/integrity/integck.c
index 1801b20..155b619 100644
--- a/tests/fs-tests/integrity/integck.c
+++ b/tests/fs-tests/integrity/integck.c
@@ -425,8 +425,6 @@  static void link_new(struct dir_info *parent, const char *name,
 	char *path, *target;
 	int ret;
-	if (!file)
-		return;
 	entry = file->links;
 	if (!entry)