Patchwork [4/6] fs-tests: integck: remove unnecessary check

login
register
mail settings
Submitter Artem Bityutskiy
Date April 8, 2011, 3:16 p.m.
Message ID <1302275810-12632-5-git-send-email-dedekind1@gmail.com>
Download mbox | patch
Permalink /patch/90382/
State New
Headers show

Comments

Artem Bityutskiy - April 8, 2011, 3:16 p.m.
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

The 'link_new()' function has only one user, and the user checks
that the third 'file' argument is non NULL, so remove this check
from 'link_new()'. Let's be consistent and assume the 3rd argument
is never NULL, just like the first and the second ones.

This is just a minor improvement.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 tests/fs-tests/integrity/integck.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Patch

diff --git a/tests/fs-tests/integrity/integck.c b/tests/fs-tests/integrity/integck.c
index 1801b20..155b619 100644
--- a/tests/fs-tests/integrity/integck.c
+++ b/tests/fs-tests/integrity/integck.c
@@ -425,8 +425,6 @@  static void link_new(struct dir_info *parent, const char *name,
 	char *path, *target;
 	int ret;
 
-	if (!file)
-		return;
 	entry = file->links;
 	if (!entry)
 		return;