[RFC,5/9] testcases: logrotate: Check if "file" command exists
diff mbox series

Message ID 20180423094639.14612-6-mylene.josserand@bootlin.com
State Accepted
Delegated to: Cyril Hrubis
Headers show
Series
  • testcases: small improvements with TCONF
Related show

Commit Message

Mylène Josserand April 23, 2018, 9:46 a.m. UTC
Add "file" binary in the list of commands to check if
they exist or not.

Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com>
---
 testcases/commands/logrotate/logrotate_tests.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Petr Vorel May 16, 2018, 9:45 a.m. UTC | #1
Hi Mylène,

> Add "file" binary in the list of commands to check if
> they exist or not.

> Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com>
> ---
>  testcases/commands/logrotate/logrotate_tests.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

> diff --git a/testcases/commands/logrotate/logrotate_tests.sh b/testcases/commands/logrotate/logrotate_tests.sh
> index f5a22ddde..021972294 100755
> --- a/testcases/commands/logrotate/logrotate_tests.sh
> +++ b/testcases/commands/logrotate/logrotate_tests.sh
> @@ -97,10 +97,11 @@ init()
>  		 return $RC
>  	fi

> -	# check if commands tst_*, logrotate, awk exists.
> +	# check if commands tst_*, logrotate, awk and file exists.
>  	chk_ifexists INIT tst_resm  || return $RC
>  	chk_ifexists INIT logrotate || return $RC
>  	chk_ifexists INIT awk       || return $RC
> +	chk_ifexists INIT file      || return $RC

>  	return $RC
>  }

Pushed, thanks.


Kind regards,
Petr
Petr Vorel May 16, 2018, 10:20 a.m. UTC | #2
Hi Mylène,

> Add "file" binary in the list of commands to check if
> they exist or not.

> Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com>
> ---
>  testcases/commands/logrotate/logrotate_tests.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

> diff --git a/testcases/commands/logrotate/logrotate_tests.sh b/testcases/commands/logrotate/logrotate_tests.sh
> index f5a22ddde..021972294 100755
> --- a/testcases/commands/logrotate/logrotate_tests.sh
> +++ b/testcases/commands/logrotate/logrotate_tests.sh
> @@ -97,10 +97,11 @@ init()
>  		 return $RC
>  	fi

> -	# check if commands tst_*, logrotate, awk exists.
> +	# check if commands tst_*, logrotate, awk and file exists.
>  	chk_ifexists INIT tst_resm  || return $RC
>  	chk_ifexists INIT logrotate || return $RC
>  	chk_ifexists INIT awk       || return $RC
> +	chk_ifexists INIT file      || return $RC

>  	return $RC
>  }

Pushed, thanks.


Kind regards,
Petr

Patch
diff mbox series

diff --git a/testcases/commands/logrotate/logrotate_tests.sh b/testcases/commands/logrotate/logrotate_tests.sh
index f5a22ddde..021972294 100755
--- a/testcases/commands/logrotate/logrotate_tests.sh
+++ b/testcases/commands/logrotate/logrotate_tests.sh
@@ -97,10 +97,11 @@  init()
 		 return $RC
 	fi
 
-	# check if commands tst_*, logrotate, awk exists.
+	# check if commands tst_*, logrotate, awk and file exists.
 	chk_ifexists INIT tst_resm  || return $RC
 	chk_ifexists INIT logrotate || return $RC
 	chk_ifexists INIT awk       || return $RC
+	chk_ifexists INIT file      || return $RC
 
 	return $RC
 }