From patchwork Fri Apr 8 08:05:37 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Herrmann X-Patchwork-Id: 90283 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 94D9DB6F8E for ; Fri, 8 Apr 2011 18:05:56 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756095Ab1DHIFx (ORCPT ); Fri, 8 Apr 2011 04:05:53 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:58213 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756089Ab1DHIFl (ORCPT ); Fri, 8 Apr 2011 04:05:41 -0400 Received: by fxm17 with SMTP id 17so2173247fxm.19 for ; Fri, 08 Apr 2011 01:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:message-id; bh=FPyyJQfmWhlNc376dF+dAsHUmJcWRV5EChFsi8sJljU=; b=mskFZo/DnmlC6vu4xHMvmHdHiqlZ1IigOLIT0A0J1eJp+s391ylgkgy+nhYp9e7y41 ZN+1OlenR4/nZrvFd1onfbNAWyRGfr4HsXmA4UdCmexp5U84WmV8EgbwinKjEO9A+LBe nLow9mO+cvatn3NzPVMERiTGuJMKvjw7OOfTY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:message-id; b=ESvedMaOecqZR42gf98kBhCv3pmuMfbeIdo0B5FqzvlO0hTgDSsNhzHtatDSfM2N10 yHfQK8OXni7b4y5Svior0MTgSLasAK4urEbwl/LJ7Ota/9FVOmgj9aGPG2BKBtdU3Cid axIq5yGwNHSwqp1Q8T84zfnCFgPg4BqJT6OZ4= Received: by 10.223.43.145 with SMTP id w17mr417703fae.12.1302249940195; Fri, 08 Apr 2011 01:05:40 -0700 (PDT) Received: from bloomfield.localnet (pavelherrmann.kolej.mff.cuni.cz [78.128.197.20]) by mx.google.com with ESMTPS id e17sm706797fak.24.2011.04.08.01.05.38 (version=SSLv3 cipher=OTHER); Fri, 08 Apr 2011 01:05:38 -0700 (PDT) From: Pavel Herrmann To: Jeff Garzik Subject: Re: [PATCH] support for PMP used in TT BlackX Duet drive dock Date: Fri, 8 Apr 2011 10:05:37 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.33-gentoo-r1; KDE/4.6.1; x86_64; ; ) Cc: Tejun Heo , linux-ide@vger.kernel.org References: <201104071854.10911.morpheus.ibis@gmail.com> <201104072140.59548.morpheus.ibis@gmail.com> <4D9E9605.7030304@garzik.org> In-Reply-To: <4D9E9605.7030304@garzik.org> MIME-Version: 1.0 Message-Id: <201104081005.37191.morpheus.ibis@gmail.com> Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Friday 08 of April 2011 06:58:45 Jeff Garzik wrote: > So you're gonna resend this as a real patch, right? :) right :) this is the tested version (call it V2 if you wish), against 29-rc2 and 28- gentoo-r1 (no difference in this file), works in both I still have no idea what those quirks really do, so test before including thanks Pavel Herrmann From a7b09f275faca338805fd697ab41fd13d7f21d41 Mon Sep 17 00:00:00 2001 From: Pavel Herrmann Date: Thu, 7 Apr 2011 18:15:26 +0200 Subject: [PATCH] libata-pmp: add support for Thermaltake BlackX Duet esata drive dock some errors still show up, but the dock works, both drives can be accessed at the same time the chip maker and designation is unknown - possibly jmicron JMB350? Signed-off-by: Pavel Herrmann --- drivers/ata/libata-pmp.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c index 3120596..e6e409d 100644 --- a/drivers/ata/libata-pmp.c +++ b/drivers/ata/libata-pmp.c @@ -449,6 +449,16 @@ static void sata_pmp_quirks(struct ata_port *ap) * otherwise. Don't try hard to recover it. */ ap->pmp_link[ap->nr_pmp_links - 1].flags |= ATA_LFLAG_NO_RETRY; + } else if (vendor == 0x197b && devid == 0x2352) { + /* chip found in Thermaltake BlackX Duet, jmicron JMB350? */ + ata_for_each_link(link, ap, EDGE) { + /* Use same quirks as sil chips to make it work, + * not everything might be necessary though + */ + link->flags |= ATA_LFLAG_NO_LPM | + ATA_LFLAG_NO_SRST | + ATA_LFLAG_ASSUME_ATA; + } } } -- 1.7.4.1