| Message ID | 20180423012923.121147-1-edumazet@google.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] ipv6: add RTA_TABLE and RTA_PREFSRC to rtm_ipv6_policy | expand |
On 4/22/18 7:29 PM, Eric Dumazet wrote: > KMSAN reported use of uninit-value that I tracked to lack > of proper size check on RTA_TABLE attribute. > > I also believe RTA_PREFSRC lacks a similar check. > > Fixes: 86872cb57925 ("[IPv6] route: FIB6 configuration using struct fib6_config") > Fixes: c3968a857a6b ("ipv6: RTA_PREFSRC support for ipv6 route source address selection") > Signed-off-by: Eric Dumazet <edumazet@google.com> > Reported-by: syzbot <syzkaller@googlegroups.com> > --- > net/ipv6/route.c | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: David Ahern <dsahern@gmail.com>
From: Eric Dumazet <edumazet@google.com> Date: Sun, 22 Apr 2018 18:29:23 -0700 > KMSAN reported use of uninit-value that I tracked to lack > of proper size check on RTA_TABLE attribute. > > I also believe RTA_PREFSRC lacks a similar check. > > Fixes: 86872cb57925 ("[IPv6] route: FIB6 configuration using struct fib6_config") > Fixes: c3968a857a6b ("ipv6: RTA_PREFSRC support for ipv6 route source address selection") > Signed-off-by: Eric Dumazet <edumazet@google.com> > Reported-by: syzbot <syzkaller@googlegroups.com> Applied and queued up for -stable, thanks Eric.
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 49b954d6d0fa44ea0c4427e2918b3ab9c1610fe0..cde7d8251377c1a115e02c46843d361d3c0b4313 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -3975,6 +3975,7 @@ void rt6_mtu_change(struct net_device *dev, unsigned int mtu) static const struct nla_policy rtm_ipv6_policy[RTA_MAX+1] = { [RTA_GATEWAY] = { .len = sizeof(struct in6_addr) }, + [RTA_PREFSRC] = { .len = sizeof(struct in6_addr) }, [RTA_OIF] = { .type = NLA_U32 }, [RTA_IIF] = { .type = NLA_U32 }, [RTA_PRIORITY] = { .type = NLA_U32 }, @@ -3986,6 +3987,7 @@ static const struct nla_policy rtm_ipv6_policy[RTA_MAX+1] = { [RTA_EXPIRES] = { .type = NLA_U32 }, [RTA_UID] = { .type = NLA_U32 }, [RTA_MARK] = { .type = NLA_U32 }, + [RTA_TABLE] = { .type = NLA_U32 }, }; static int rtm_to_fib6_config(struct sk_buff *skb, struct nlmsghdr *nlh,
KMSAN reported use of uninit-value that I tracked to lack of proper size check on RTA_TABLE attribute. I also believe RTA_PREFSRC lacks a similar check. Fixes: 86872cb57925 ("[IPv6] route: FIB6 configuration using struct fib6_config") Fixes: c3968a857a6b ("ipv6: RTA_PREFSRC support for ipv6 route source address selection") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> --- net/ipv6/route.c | 2 ++ 1 file changed, 2 insertions(+)