| Message ID | 20180421120011.16906-1-erosca@de.adit-jv.com |
|---|---|
| State | Accepted |
| Commit | 39883af3f0a8e3e481752026fa7f3cfa2f506e4e |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] lib/rsa: Kconfig: Remove superfluous 'depends on RSA' | expand |
On 21 April 2018 at 06:00, Eugeniu Rosca <roscaeugeniu@gmail.com> wrote: > RSA_SOFTWARE_EXP and RSA_FREESCALE_EXP are wrapped inside: > > if RSA > ... > endif > > So, remove the redundant "depends on RSA" from their depends expression. > In addition, move SPL_RSA into the same "if RSA ... endif" block, since > its only direct dependeny is CONFIG_RSA. This tidies up and simplifies > reading of lib/rsa/Kconfig. > > No functional change intended. > > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> > --- > lib/rsa/Kconfig | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Sat, Apr 21, 2018 at 02:00:10PM +0200, Eugeniu Rosca wrote: > RSA_SOFTWARE_EXP and RSA_FREESCALE_EXP are wrapped inside: > > if RSA > ... > endif > > So, remove the redundant "depends on RSA" from their depends expression. > In addition, move SPL_RSA into the same "if RSA ... endif" block, since > its only direct dependeny is CONFIG_RSA. This tidies up and simplifies > reading of lib/rsa/Kconfig. > > No functional change intended. > > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig index fde1ac108d0f..2b33f323bccc 100644 --- a/lib/rsa/Kconfig +++ b/lib/rsa/Kconfig @@ -13,14 +13,14 @@ config RSA option. The software based modular exponentiation is built into mkimage irrespective of this option. +if RSA + config SPL_RSA bool "Use RSA Library within SPL" - depends on RSA -if RSA config RSA_SOFTWARE_EXP bool "Enable driver for RSA Modular Exponentiation in software" - depends on DM && RSA + depends on DM help Enables driver for modular exponentiation in software. This is a RSA algorithm used in FIT image verification. It required RSA Key as @@ -29,7 +29,7 @@ config RSA_SOFTWARE_EXP config RSA_FREESCALE_EXP bool "Enable RSA Modular Exponentiation with FSL crypto accelerator" - depends on DM && RSA && FSL_CAAM && !ARCH_MX7 && !ARCH_MX6 && !ARCH_MX5 + depends on DM && FSL_CAAM && !ARCH_MX7 && !ARCH_MX6 && !ARCH_MX5 help Enables driver for RSA modular exponentiation using Freescale cryptographic accelerator - CAAM.
RSA_SOFTWARE_EXP and RSA_FREESCALE_EXP are wrapped inside: if RSA ... endif So, remove the redundant "depends on RSA" from their depends expression. In addition, move SPL_RSA into the same "if RSA ... endif" block, since its only direct dependeny is CONFIG_RSA. This tidies up and simplifies reading of lib/rsa/Kconfig. No functional change intended. Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> --- lib/rsa/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)