[next] cifs: ensure full_path is free'd on error exit path

Message ID 20180420131519.30510-1-colin.king@canonical.com
State New
Headers show
  • [next] cifs: ensure full_path is free'd on error exit path
Related show

Commit Message

Colin Ian King April 20, 2018, 1:15 p.m.
From: Colin Ian King <colin.king@canonical.com>

Currently the check on the mode flags that returns -EPERM is leaking
full_path on the error exit return. Fix this by kfree'ing it before
the return.

Detected by CoverityScan, CID#1468029 ("Resource Leak")

Fixes: 49162bfde140 ("cifs: do not allow creating sockets except with SMB1 posix exensions")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
 fs/cifs/dir.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
index f0a759dd6817..207883b39362 100644
--- a/fs/cifs/dir.c
+++ b/fs/cifs/dir.c
@@ -684,8 +684,10 @@  int cifs_mknod(struct inode *inode, struct dentry *direntry, umode_t mode,
 		goto mknod_out;
-	if (!S_ISCHR(mode) && !S_ISBLK(mode))
+	if (!S_ISCHR(mode) && !S_ISBLK(mode)) {
+		kfree(full_path);
 		return -EPERM;
+	}
 	if (!(cifs_sb->mnt_cifs_flags & CIFS_MOUNT_UNX_EMUL))
 		goto mknod_out;