diff mbox series

[U-Boot,01/10] rockchip: enable DEBUG_UART_BOARD_INIT by default

Message ID 1524199258-14611-2-git-send-email-kever.yang@rock-chips.com
State Superseded
Delegated to: Philipp Tomsich
Headers show
Series rockchip: enable board_debug_uart_init for all soc | expand

Commit Message

Kever Yang April 20, 2018, 4:40 a.m. UTC
All Rockchip SoCs use DEBUG_UART_BOARD_INIT to init per board
UART IOMUX, enable it by default.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 arch/arm/Kconfig               | 2 ++
 arch/arm/mach-rockchip/Kconfig | 3 ---
 2 files changed, 2 insertions(+), 3 deletions(-)

Comments

Philipp Tomsich Aug. 29, 2018, 6:33 p.m. UTC | #1
> All Rockchip SoCs use DEBUG_UART_BOARD_INIT to init per board
> UART IOMUX, enable it by default.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  arch/arm/Kconfig               | 2 ++
>  arch/arm/mach-rockchip/Kconfig | 3 ---
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich Aug. 29, 2018, 6:43 p.m. UTC | #2
Kever,

Could you rebase this series to u-boot-rockchip/next and resubmit?
I’d like to avoid any issues from manually fixing up git-am issues (as I happened to introduce on last set of UART changes).

Thanks,
Philipp.

> On 29 Aug 2018, at 20:33, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote:
> 
>> All Rockchip SoCs use DEBUG_UART_BOARD_INIT to init per board
>> UART IOMUX, enable it by default.
>> 
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>> 
>> arch/arm/Kconfig               | 2 ++
>> arch/arm/mach-rockchip/Kconfig | 3 ---
>> 2 files changed, 2 insertions(+), 3 deletions(-)
>> 
> 
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Philipp Tomsich Aug. 29, 2018, 6:45 p.m. UTC | #3
> All Rockchip SoCs use DEBUG_UART_BOARD_INIT to init per board
> UART IOMUX, enable it by default.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  arch/arm/Kconfig               | 2 ++
>  arch/arm/mach-rockchip/Kconfig | 3 ---
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Kever Yang Aug. 30, 2018, 1:04 a.m. UTC | #4
Philipp,

Sure, I can do it.


Thanks,
- Kever
On 08/30/2018 02:43 AM, Dr. Philipp Tomsich wrote:
> Kever,
>
> Could you rebase this series to u-boot-rockchip/next and resubmit?
> I’d like to avoid any issues from manually fixing up git-am issues (as I happened to introduce on last set of UART changes).
>
> Thanks,
> Philipp.
>
>> On 29 Aug 2018, at 20:33, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote:
>>
>>> All Rockchip SoCs use DEBUG_UART_BOARD_INIT to init per board
>>> UART IOMUX, enable it by default.
>>>
>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>>> ---
>>>
>>> arch/arm/Kconfig               | 2 ++
>>> arch/arm/mach-rockchip/Kconfig | 3 ---
>>> 2 files changed, 2 insertions(+), 3 deletions(-)
>>>
>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> https://lists.denx.de/listinfo/u-boot
>
Philipp Tomsich Oct. 12, 2018, 11:04 a.m. UTC | #5
Kever,

Did I miss the rebased series?
Also note that next is not current at the moment (I haven’t started on next yet), so best to rebase onto the Tom’s master.

Thanks,
Philipp.

> On 30.08.2018, at 03:04, Kever Yang <kever.yang@rock-chips.com> wrote:
> 
> Philipp,
> 
> Sure, I can do it.
> 
> 
> Thanks,
> - Kever
> On 08/30/2018 02:43 AM, Dr. Philipp Tomsich wrote:
>> Kever,
>> 
>> Could you rebase this series to u-boot-rockchip/next and resubmit?
>> I’d like to avoid any issues from manually fixing up git-am issues (as I happened to introduce on last set of UART changes).
>> 
>> Thanks,
>> Philipp.
>> 
>>> On 29 Aug 2018, at 20:33, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote:
>>> 
>>>> All Rockchip SoCs use DEBUG_UART_BOARD_INIT to init per board
>>>> UART IOMUX, enable it by default.
>>>> 
>>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>>>> ---
>>>> 
>>>> arch/arm/Kconfig               | 2 ++
>>>> arch/arm/mach-rockchip/Kconfig | 3 ---
>>>> 2 files changed, 2 insertions(+), 3 deletions(-)
>>>> 
>>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot@lists.denx.de
>>> https://lists.denx.de/listinfo/u-boot
>> 
> 
>
diff mbox series

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index a90f870..97e4a93 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1191,6 +1191,7 @@  config ARCH_ROCKCHIP
 	select DM_PWM
 	select DM_REGULATOR
 	select ENABLE_ARM_SOC_BOOT0_HOOK
+	select DEBUG_UART_BOARD_INIT
 	imply CMD_FASTBOOT
 	imply FASTBOOT
 	imply FAT_WRITE
@@ -1201,6 +1202,7 @@  config ARCH_ROCKCHIP
 	imply SARADC_ROCKCHIP
 	imply SYS_NS16550
 
+
 config TARGET_THUNDERX_88XX
 	bool "Support ThunderX 88xx"
 	select ARM64
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 41f529c..ccb9fa6 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -50,7 +50,6 @@  config ROCKCHIP_RK322X
 	select SUPPORT_SPL
 	select SPL
 	select ROCKCHIP_BROM_HELPER
-	select DEBUG_UART_BOARD_INIT
 	help
 	  The Rockchip RK3229 is a ARM-based SoC with a dual-core Cortex-A7
 	  including NEON and GPU, Mali-400 graphics, several DDR3 options
@@ -102,7 +101,6 @@  config ROCKCHIP_RK3368
 	imply SPL_SEPARATE_BSS
 	imply SPL_SERIAL_SUPPORT
 	imply TPL_SERIAL_SUPPORT
-	select DEBUG_UART_BOARD_INIT
 	help
 	  The Rockchip RK3368 is a ARM-based SoC with a octa-core (organised
 	  into a big and little cluster with 4 cores each) Cortex-A53 including
@@ -138,7 +136,6 @@  config ROCKCHIP_RK3399
 	select SPL_SEPARATE_BSS
 	select SPL_SERIAL_SUPPORT
 	select SPL_DRIVERS_MISC_SUPPORT
-	select DEBUG_UART_BOARD_INIT
 	select BOARD_LATE_INIT
 	select ROCKCHIP_BROM_HELPER
 	help