| Message ID | 20180419200246.13613-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 83a1f933d141ca5db69344559c1eef255d45fddd |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,1/1] cmd: CONFIG_CMD_LOG select CONFIG_LOG | expand |
On 19 April 2018 at 14:02, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > CONFIG_CMD_LOG without CONFIG_LOG leads to a build error: > ‘gd_t {aka volatile struct global_data}’ has no member named > ‘default_log_level’ > > So CMD_LOG should select LOG. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > cmd/Kconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass <sjg@chromium.org>
On Thu, Apr 19, 2018 at 10:02:46PM +0200, Heinrich Schuchardt wrote: > CONFIG_CMD_LOG without CONFIG_LOG leads to a build error: > ‘gd_t {aka volatile struct global_data}’ has no member named > ‘default_log_level’ > > So CMD_LOG should select LOG. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/cmd/Kconfig b/cmd/Kconfig index bc1d2f31c0..225bb002a6 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1660,6 +1660,7 @@ config CMD_KGDB config CMD_LOG bool "log - Generation, control and access to logging" + select LOG help This provides access to logging features. It allows the output of log data to be controlled to a limited extent (setting up the default
CONFIG_CMD_LOG without CONFIG_LOG leads to a build error: ‘gd_t {aka volatile struct global_data}’ has no member named ‘default_log_level’ So CMD_LOG should select LOG. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- cmd/Kconfig | 1 + 1 file changed, 1 insertion(+)