Message ID | 20180419195904.13415-1-xypron.glpk@gmx.de |
---|---|
State | Accepted |
Commit | 9adc78d278bec84b638aa3b25b102f3cfb21438c |
Delegated to: | Tom Rini |
Headers | show |
Series | [U-Boot,1/1] log: CONFIG_LOG should select CONFIG_DM | expand |
On 19 April 2018 at 13:59, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > Compling with CONFIG_LOG and without CONFIG_DM results in > common/log.c:47: undefined reference to `uclass_get_name' > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > common/Kconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass <sjg@chromium.org> Or should we solve this with an #ifdef?
On Thu, Apr 19, 2018 at 09:59:04PM +0200, Heinrich Schuchardt wrote: > Compling with CONFIG_LOG and without CONFIG_DM results in > common/log.c:47: undefined reference to `uclass_get_name' > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/common/Kconfig b/common/Kconfig index 03eeeb2402..4c7a1a9af8 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -424,6 +424,7 @@ menu "Logging" config LOG bool "Enable logging support" + select DM help This enables support for logging of status and debug messages. These can be displayed on the console, recorded in a memory buffer, or
Compling with CONFIG_LOG and without CONFIG_DM results in common/log.c:47: undefined reference to `uclass_get_name' Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- common/Kconfig | 1 + 1 file changed, 1 insertion(+)