Message ID | 20180419135524.44727-1-Evgeniy.Didin@synopsys.com |
---|---|
State | Changes Requested |
Headers | show |
Series | configs/snps_arc*_defconfig: update linux version | expand |
Hello, On Thu, 19 Apr 2018 16:55:24 +0300, Evgeniy Didin wrote: > With this commit we update Linux kernel version to 4.16.3 > and Linux headers version to 4.16. > For some configs we switch headers version to be independent from > Linux kernel version. Why ? The change doesn't make you independent at all from the Linux kernel version, and causes two kernel tarballs to be downloaded instead of one, which isn't nice. Could you justify this change ? (side note: could you use my @bootlin.com address instead of @free-electrons.com. The DEVELOPERS file has been updated since quite some time about this already. Thanks a lot!) Thanks, Thomas
Hello, > Hello, > > On Thu, 19 Apr 2018 16:55:24 +0300, Evgeniy Didin wrote: > > With this commit we update Linux kernel version to 4.16.3 > > and Linux headers version to 4.16. > > For some configs we switch headers version to be independent from > > Linux kernel version. > > Why ? The change doesn't make you independent at all from the Linux > kernel version, and causes two kernel tarballs to be downloaded instead > of one, which isn't nice. > > Could you justify this change ? With option BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1*=y BR2_KERNEL_HEADERS_AS_KERNEL parameter is set. Defconfig is meant as a starting point for work with the board. In these case if user wants to change version of Linux kernel, such error appears: ---------------------------->8--------------------------------- Incorrect selection of kernel headers: expected 4.16.x, got 4.15.x, ----------------------------8<--------------------------------- Also in case of choosing new kernel rc's, error 404 occurs. For inexperienced users, these errors may not be obvious. > (side note: could you use my @bootlin.com address instead of > @free-electrons.com. The DEVELOPERS file has been updated since quite > some time about this already. Thanks a lot!) Sure Best regards, Evgeniy Didin
Hello Evgeniy, On Thu, 19 Apr 2018 15:16:51 +0000, Evgeniy Didin wrote: > Hello, > > > Hello, > > > > On Thu, 19 Apr 2018 16:55:24 +0300, Evgeniy Didin wrote: > > > With this commit we update Linux kernel version to 4.16.3 > > > and Linux headers version to 4.16. > > > For some configs we switch headers version to be independent from > > > Linux kernel version. > > > > Why ? The change doesn't make you independent at all from the Linux > > kernel version, and causes two kernel tarballs to be downloaded instead > > of one, which isn't nice. > > > > Could you justify this change ? > > With option BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1*=y > BR2_KERNEL_HEADERS_AS_KERNEL parameter is set. Yes, and this is what we want. > Defconfig is meant as a starting point for work with the board. > In these case if user wants to change version of Linux kernel, > such error appears: > ---------------------------->8--------------------------------- > Incorrect selection of kernel headers: expected 4.16.x, got 4.15.x, > ----------------------------8<--------------------------------- > Also in case of choosing new kernel rc's, error 404 occurs. > For inexperienced users, these errors may not be obvious. I do understand your concern. However, it is actually even worse if your defconfig selects 4.16 kernel headers: if the user changes the kernel version itself from 4.16 to 4.10, the user will run a 4.10 kernel, with a toolchain compiled against 4.16 kernel headers, which isn't good. Also, specifying a fixed kernel headers version like you're doing means that the kernel source code gets downloaded twice. In addition all our defconfigs use this principle, and we are not going to change this principle for just a few defconfigs. Either we change this for all defconfigs, or we keep it as is for all defconfigs. Therefore, I would recommend you to bump the Linux kernel version in the snps_arc_* defconfigs without changing this, and if you really think the current situation is not convenient, open up the discussion inn a broader way. Thanks! Thomas
diff --git a/configs/snps_arc700_axs101_defconfig b/configs/snps_arc700_axs101_defconfig index 0fefaf4aa8..fef5a49fdd 100644 --- a/configs/snps_arc700_axs101_defconfig +++ b/configs/snps_arc700_axs101_defconfig @@ -8,13 +8,13 @@ BR2_TARGET_ROOTFS_INITRAMFS=y BR2_SYSTEM_DHCP="eth0" BR2_ROOTFS_OVERLAY="board/synopsys/axs10x/fs-overlay" -# Linux headers same as kernel, a 4.15 series -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_15=y +# Linux headers +BR2_KERNEL_HEADERS_4_16=y # Kernel BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.15" +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.16.3" BR2_LINUX_KERNEL_DEFCONFIG="axs101" BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y diff --git a/configs/snps_archs38_axs103_defconfig b/configs/snps_archs38_axs103_defconfig index 39ceeae433..f6e94aff3c 100644 --- a/configs/snps_archs38_axs103_defconfig +++ b/configs/snps_archs38_axs103_defconfig @@ -9,13 +9,13 @@ BR2_TARGET_ROOTFS_INITRAMFS=y BR2_SYSTEM_DHCP="eth0" BR2_ROOTFS_OVERLAY="board/synopsys/axs10x/fs-overlay" -# Linux headers same as kernel, a 4.15 series -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_15=y +# Linux headers +BR2_KERNEL_HEADERS_4_16=y # Kernel BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.15" +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.16.3" BR2_LINUX_KERNEL_DEFCONFIG="axs103_smp" BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y diff --git a/configs/snps_archs38_haps_defconfig b/configs/snps_archs38_haps_defconfig index 6583c1ec3a..554d12f0bb 100644 --- a/configs/snps_archs38_haps_defconfig +++ b/configs/snps_archs38_haps_defconfig @@ -7,12 +7,12 @@ BR2_TARGET_GENERIC_HOSTNAME="zebu_hs" BR2_TARGET_GENERIC_ISSUE="Welcome to the HAPS Development Platform" BR2_TARGET_ROOTFS_INITRAMFS=y -# Linux headers same as kernel, a 4.15 series -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_15=y +# Linux headers +BR2_KERNEL_HEADERS_4_16=y # Kernel BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.15" +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.16.3" BR2_LINUX_KERNEL_DEFCONFIG="haps_hs_smp" BR2_LINUX_KERNEL_VMLINUX=y diff --git a/configs/snps_archs38_hsdk_defconfig b/configs/snps_archs38_hsdk_defconfig index 125063b444..30b5301dca 100644 --- a/configs/snps_archs38_hsdk_defconfig +++ b/configs/snps_archs38_hsdk_defconfig @@ -3,7 +3,7 @@ BR2_arcle=y BR2_archs38=y # Linux headers -BR2_KERNEL_HEADERS_4_14=y +BR2_KERNEL_HEADERS_4_16=y # System BR2_TARGET_GENERIC_HOSTNAME="hsdk" @@ -13,7 +13,7 @@ BR2_SYSTEM_DHCP="eth0" # Kernel BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14.4" +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.16.3" BR2_LINUX_KERNEL_DEFCONFIG="hsdk" BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/synopsys/hsdk/linux.fragment" diff --git a/configs/snps_archs38_vdk_defconfig b/configs/snps_archs38_vdk_defconfig index 46b539beec..5be134de81 100644 --- a/configs/snps_archs38_vdk_defconfig +++ b/configs/snps_archs38_vdk_defconfig @@ -8,13 +8,13 @@ BR2_TARGET_GENERIC_ISSUE="Welcome to the HS38 VDK Software Development Platform" BR2_ROOTFS_OVERLAY="board/synopsys/axs10x/fs-overlay" BR2_TARGET_ROOTFS_EXT2=y -# Linux headers same as kernel, a 4.15 series -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_15=y +# Linux headers +BR2_KERNEL_HEADERS_4_16=y # Kernel BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_VERSION=y -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.15" +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.16.3" BR2_LINUX_KERNEL_DEFCONFIG="vdk_hs38_smp" BR2_LINUX_KERNEL_VMLINUX=y BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
With this commit we update Linux kernel version to 4.16.3 and Linux headers version to 4.16. For some configs we switch headers version to be independent from Linux kernel version. Signed-off-by: Evgeniy Didin <didin@synopsys.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Alexey Brodkin <abrodkin@synopsys.com> Cc: arc-buildroot@synopsys.com --- configs/snps_arc700_axs101_defconfig | 6 +++--- configs/snps_archs38_axs103_defconfig | 6 +++--- configs/snps_archs38_haps_defconfig | 6 +++--- configs/snps_archs38_hsdk_defconfig | 4 ++-- configs/snps_archs38_vdk_defconfig | 6 +++--- 5 files changed, 14 insertions(+), 14 deletions(-)