| Message ID | 20180418180607.11843-1-jakub.kicinski@netronome.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute2] iplink_geneve: correct size of message to avoid spurious errors | expand |
On Wed, Apr 18, 2018 at 11:06 AM, Jakub Kicinski <jakub.kicinski@netronome.com> wrote: > Commit 6c4b672738ac ("iplink_geneve: Get rid of inet_get_addr()") > inadvertently changed the parameter to addattr_l() resulting in: > > addattr_l ERROR: message exceeded bound of 4 > > when remote is specified. > > Fixes: 6c4b672738ac ("iplink_geneve: Get rid of inet_get_addr()") > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> > Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com> > --- Thanks. We also hit this issue when creating geneve tunnel. Acked-by: William Tu <u9012063@gmail.com>
diff --git a/ip/iplink_geneve.c b/ip/iplink_geneve.c index 1fcdd83acca9..26e70ff4db42 100644 --- a/ip/iplink_geneve.c +++ b/ip/iplink_geneve.c @@ -199,7 +199,7 @@ static int geneve_parse_opt(struct link_util *lu, int argc, char **argv, if (is_addrtype_inet(&daddr)) { int type = (daddr.family == AF_INET) ? IFLA_GENEVE_REMOTE : IFLA_GENEVE_REMOTE6; - addattr_l(n, sizeof(1024), type, daddr.data, daddr.bytelen); + addattr_l(n, 1024, type, daddr.data, daddr.bytelen); } if (!set_op || GENEVE_ATTRSET(attrs, IFLA_GENEVE_LABEL)) addattr32(n, 1024, IFLA_GENEVE_LABEL, label);
Commit 6c4b672738ac ("iplink_geneve: Get rid of inet_get_addr()") inadvertently changed the parameter to addattr_l() resulting in: addattr_l ERROR: message exceeded bound of 4 when remote is specified. Fixes: 6c4b672738ac ("iplink_geneve: Get rid of inet_get_addr()") Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com> --- ip/iplink_geneve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)