| Message ID | 1524073978-66929-1-git-send-email-dlu998@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,v1] netdev: If MTU set fails, issue warn log. | expand |
On Wed, Apr 18, 2018 at 10:52:58AM -0700, Darrell Ball wrote: > Recently, an issue was debugged that was thought to be a bond > failover triggered issue. It turned out to an vlan interface MTU set issue > that had nothing to do with bonding or most other likely possibilities. > Besides the effect of not setting the MTU to the desired value, this can > result in increased netlink traffic and processing with associated wasted > work. Let us flag a configuration issue at warn level (rather than dbg) to > catch the problem early. > > Signed-off-by: Darrell Ball <dlu998@gmail.com> Thanks, applied to master. It's funny that this was originally a WARN but was changed to DBG without any real rationale in commit 9b02078077b6 ("datapath: Strip down vport interface : OVS_VPORT_ATTR_MTU") in 2011.
diff --git a/lib/netdev.c b/lib/netdev.c index a418d9a..8f09004 100644 --- a/lib/netdev.c +++ b/lib/netdev.c @@ -951,7 +951,7 @@ netdev_set_mtu(struct netdev *netdev, int mtu) error = class->set_mtu ? class->set_mtu(netdev, mtu) : EOPNOTSUPP; if (error && error != EOPNOTSUPP) { - VLOG_DBG_RL(&rl, "failed to set MTU for network device %s: %s", + VLOG_WARN_RL(&rl, "failed to set MTU for network device %s: %s", netdev_get_name(netdev), ovs_strerror(error)); }
Recently, an issue was debugged that was thought to be a bond failover triggered issue. It turned out to an vlan interface MTU set issue that had nothing to do with bonding or most other likely possibilities. Besides the effect of not setting the MTU to the desired value, this can result in increased netlink traffic and processing with associated wasted work. Let us flag a configuration issue at warn level (rather than dbg) to catch the problem early. Signed-off-by: Darrell Ball <dlu998@gmail.com> --- lib/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)