| Message ID | 20180418153646.20623-2-svaidy@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] core: Fix iteration condition to skip garded cpu | expand |
On Wed, 18 Apr 2018 21:06:46 +0530 Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com> wrote: > Direct control xscom can take more time to complete. We seem to > wait too little on Boston failing fast-reboot for no good reason. > > Increase timeout to 1 sec as a reasonable value for sreset to be delivered > and core to start executing instructions. > > Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com> > --- > core/fast-reboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/core/fast-reboot.c b/core/fast-reboot.c > index 2be12bd2..8686aca7 100644 > --- a/core/fast-reboot.c > +++ b/core/fast-reboot.c > @@ -163,7 +163,7 @@ void fast_reboot(void) > } > > /* Ensure all the sresets get through */ > - if (!cpu_state_wait_all_others(cpu_state_present, msecs_to_tb(100))) { > + if (!cpu_state_wait_all_others(cpu_state_present, msecs_to_tb(1000))) { > prlog(PR_NOTICE, "RESET: Fast reboot timed out waiting for " > "secondaries to call in\n"); > return; I don't see much harm in this, it's interesting they take so long though. Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
diff --git a/core/fast-reboot.c b/core/fast-reboot.c index 2be12bd2..8686aca7 100644 --- a/core/fast-reboot.c +++ b/core/fast-reboot.c @@ -163,7 +163,7 @@ void fast_reboot(void) } /* Ensure all the sresets get through */ - if (!cpu_state_wait_all_others(cpu_state_present, msecs_to_tb(100))) { + if (!cpu_state_wait_all_others(cpu_state_present, msecs_to_tb(1000))) { prlog(PR_NOTICE, "RESET: Fast reboot timed out waiting for " "secondaries to call in\n"); return;
Direct control xscom can take more time to complete. We seem to wait too little on Boston failing fast-reboot for no good reason. Increase timeout to 1 sec as a reasonable value for sreset to be delivered and core to start executing instructions. Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com> --- core/fast-reboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)