| Message ID | 2f0c370d4308380672bd4a5afcad58a385dcf21f.1523973931.git.gustavo.pimentel@synopsys.com |
|---|---|
| State | Superseded |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | Designware EP support and code clean up | expand |
Hi Gustavo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on v4.17-rc1 next-20180418]
[cannot apply to pci/next robh/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Gustavo-Pimentel/Designware-EP-support-and-code-clean-up/20180418-214108
config: i386-randconfig-x016-201815 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
>> drivers/pci/endpoint/functions/pci-epf-test.c:471:11: warning: initializer-string for array of chars is too long
.name = "pci_epf_test_designware",
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/endpoint/functions/pci-epf-test.c:471:11: note: (near initialization for 'pci_epf_test_ids[1].name')
vim +471 drivers/pci/endpoint/functions/pci-epf-test.c
465
466 static const struct pci_epf_device_id pci_epf_test_ids[] = {
467 {
468 .name = "pci_epf_test",
469 },
470 {
> 471 .name = "pci_epf_test_designware",
472 .driver_data = (kernel_ulong_t)&data_cfg2,
473 },
474 {},
475 };
476
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/Documentation/PCI/endpoint/function/binding/pci-test.txt b/Documentation/PCI/endpoint/function/binding/pci-test.txt index 3b68b95..b321f9d 100644 --- a/Documentation/PCI/endpoint/function/binding/pci-test.txt +++ b/Documentation/PCI/endpoint/function/binding/pci-test.txt @@ -1,6 +1,8 @@ PCI TEST ENDPOINT FUNCTION name: Should be "pci_epf_test" to bind to the pci_epf_test driver. +name: Should be "pci_epf_designware" to bind to the pci_epf_test driver + with a custom configuration for the designware EP. Configurable Fields: vendorid : should be 0x104c diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c index 7cef851..3f613d2 100644 --- a/drivers/pci/endpoint/functions/pci-epf-test.c +++ b/drivers/pci/endpoint/functions/pci-epf-test.c @@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf) return 0; } +static const struct pci_epf_test_data data_cfg2 = { + .linkup_notifier = false +}; + static const struct pci_epf_device_id pci_epf_test_ids[] = { { .name = "pci_epf_test", }, + { + .name = "pci_epf_test_designware", + .driver_data = (kernel_ulong_t)&data_cfg2, + }, {}, };
Adds a seconds entry on the pci_epf_test_ids structure that disables the linkup_notifier parameter on driver for the designware EP. This allows designware EPs that doesn't have linkup notification signal to work with pcitest. Updates the binding documentation accordingly. Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> --- Change v2->v3: - Added second entry in pci_epf_test_ids structure. - Remove test_reg_bar field assignment on second entry. Changes v3->v4: - Nothing changed, just to follow the patch set version. Changes v4->v5: - Changed pci_epf_test_cfg2 to pci_epf_test_designware. Documentation/PCI/endpoint/function/binding/pci-test.txt | 2 ++ drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++++++++ 2 files changed, 10 insertions(+)