Patchwork ext4: sync the directory inode in ext4_sync_parent()

login
register
mail settings
Submitter Curt Wohlgemuth
Date April 5, 2011, 7:27 p.m.
Message ID <1302031663-13547-1-git-send-email-curtw@google.com>
Download mbox | patch
Permalink /patch/89922/
State Superseded
Headers show

Comments

Curt Wohlgemuth - April 5, 2011, 7:27 p.m.
ext4 has taken the stance that, in the absence of a journal,
when an fsync/fdatasync of an inode is done, the parent
directory should be sync'ed if this inode entry is new.
ext4_sync_parent(), which implements this, does indeed sync
the dirent pages for parent directories, but it does not
sync the directory *inode*.  This patch fixes this.

I tested this using a power fail test, which panics a
machine running a file server getting requests from a
client.  Without this patch, on about every other test run,
the server is missing many, many files that had been synced.
With this patch, on > 6 runs, I see zero files being lost.

Signed-off-by: Curt Wohlgemuth <curtw@google.com>
---
 fs/ext4/fsync.c |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)
Eric Sandeen - April 5, 2011, 7:35 p.m.
On 4/5/11 12:27 PM, Curt Wohlgemuth wrote:
> ext4 has taken the stance that, in the absence of a journal,
> when an fsync/fdatasync of an inode is done, the parent
> directory should be sync'ed if this inode entry is new.
> ext4_sync_parent(), which implements this, does indeed sync
> the dirent pages for parent directories, but it does not
> sync the directory *inode*.  This patch fixes this.
> 
> I tested this using a power fail test, which panics a
> machine running a file server getting requests from a
> client.  Without this patch, on about every other test run,
> the server is missing many, many files that had been synced.
> With this patch, on > 6 runs, I see zero files being lost.
> 
> Signed-off-by: Curt Wohlgemuth <curtw@google.com>
> ---
>  fs/ext4/fsync.c |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
> index 7f74019..a276348 100644
> --- a/fs/ext4/fsync.c
> +++ b/fs/ext4/fsync.c
> @@ -128,6 +128,7 @@ extern int ext4_flush_completed_IO(struct inode *inode)
>  static void ext4_sync_parent(struct inode *inode)
>  {
>  	struct dentry *dentry = NULL;
> +	int ret;
>  
>  	while (inode && ext4_test_inode_state(inode, EXT4_STATE_NEWENTRY)) {
>  		ext4_clear_inode_state(inode, EXT4_STATE_NEWENTRY);
> @@ -136,7 +137,15 @@ static void ext4_sync_parent(struct inode *inode)
>  		if (!dentry || !dentry->d_parent || !dentry->d_parent->d_inode)
>  			break;
>  		inode = dentry->d_parent->d_inode;
> -		sync_mapping_buffers(inode->i_mapping);
> +		ret = sync_mapping_buffers(inode->i_mapping);
> +		if (! ret) {
> +			struct writeback_control wbc = {
> +				.sync_mode = WB_SYNC_ALL,
> +				.nr_to_write = 0, /* metadata-only; caller
> +						     takes care of data */
> +			};
> +			(void)sync_inode(inode, &wbc);

I know ext4_sync_parent was a void already, but why don't we send errors back up through ext4_sync_file?

-Eric

> +		}
>  	}
>  }
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Curt Wohlgemuth - April 5, 2011, 7:43 p.m.
Hi Eric:

On Tue, Apr 5, 2011 at 12:35 PM, Eric Sandeen <sandeen@redhat.com> wrote:
> On 4/5/11 12:27 PM, Curt Wohlgemuth wrote:
>> ext4 has taken the stance that, in the absence of a journal,
>> when an fsync/fdatasync of an inode is done, the parent
>> directory should be sync'ed if this inode entry is new.
>> ext4_sync_parent(), which implements this, does indeed sync
>> the dirent pages for parent directories, but it does not
>> sync the directory *inode*.  This patch fixes this.
>>
>> I tested this using a power fail test, which panics a
>> machine running a file server getting requests from a
>> client.  Without this patch, on about every other test run,
>> the server is missing many, many files that had been synced.
>> With this patch, on > 6 runs, I see zero files being lost.
>>
>> Signed-off-by: Curt Wohlgemuth <curtw@google.com>
>> ---
>>  fs/ext4/fsync.c |   11 ++++++++++-
>>  1 files changed, 10 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
>> index 7f74019..a276348 100644
>> --- a/fs/ext4/fsync.c
>> +++ b/fs/ext4/fsync.c
>> @@ -128,6 +128,7 @@ extern int ext4_flush_completed_IO(struct inode *inode)
>>  static void ext4_sync_parent(struct inode *inode)
>>  {
>>       struct dentry *dentry = NULL;
>> +     int ret;
>>
>>       while (inode && ext4_test_inode_state(inode, EXT4_STATE_NEWENTRY)) {
>>               ext4_clear_inode_state(inode, EXT4_STATE_NEWENTRY);
>> @@ -136,7 +137,15 @@ static void ext4_sync_parent(struct inode *inode)
>>               if (!dentry || !dentry->d_parent || !dentry->d_parent->d_inode)
>>                       break;
>>               inode = dentry->d_parent->d_inode;
>> -             sync_mapping_buffers(inode->i_mapping);
>> +             ret = sync_mapping_buffers(inode->i_mapping);
>> +             if (! ret) {
>> +                     struct writeback_control wbc = {
>> +                             .sync_mode = WB_SYNC_ALL,
>> +                             .nr_to_write = 0, /* metadata-only; caller
>> +                                                  takes care of data */
>> +                     };
>> +                     (void)sync_inode(inode, &wbc);
>
> I know ext4_sync_parent was a void already, but why don't we send errors back up through ext4_sync_file?

Well, you could argue that a failure to sync the parent shouldn't
cause the inode's fsync() to fail, but I probably wouldn't :-) .  I'll
resend a patch that implements this.

Thanks,
Curt

>
> -Eric
>
>> +             }
>>       }
>>  }
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eric Sandeen - April 5, 2011, 7:46 p.m.
On 4/5/11 12:43 PM, Curt Wohlgemuth wrote:
> Well, you could argue that a failure to sync the parent shouldn't
> cause the inode's fsync() to fail, but I probably wouldn't :-) .  I'll
> resend a patch that implements this.
> 
> Thanks,
> Curt

It might be a valid argument, since we're doing it "just to be nice" - but if you're getting EIOs you'd probably rather know sooner than later...

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
index 7f74019..a276348 100644
--- a/fs/ext4/fsync.c
+++ b/fs/ext4/fsync.c
@@ -128,6 +128,7 @@  extern int ext4_flush_completed_IO(struct inode *inode)
 static void ext4_sync_parent(struct inode *inode)
 {
 	struct dentry *dentry = NULL;
+	int ret;
 
 	while (inode && ext4_test_inode_state(inode, EXT4_STATE_NEWENTRY)) {
 		ext4_clear_inode_state(inode, EXT4_STATE_NEWENTRY);
@@ -136,7 +137,15 @@  static void ext4_sync_parent(struct inode *inode)
 		if (!dentry || !dentry->d_parent || !dentry->d_parent->d_inode)
 			break;
 		inode = dentry->d_parent->d_inode;
-		sync_mapping_buffers(inode->i_mapping);
+		ret = sync_mapping_buffers(inode->i_mapping);
+		if (! ret) {
+			struct writeback_control wbc = {
+				.sync_mode = WB_SYNC_ALL,
+				.nr_to_write = 0, /* metadata-only; caller
+						     takes care of data */
+			};
+			(void)sync_inode(inode, &wbc);
+		}
 	}
 }