From patchwork Mon Apr 16 22:04:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Schmitz X-Patchwork-Id: 898969 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GSZdA7Yj"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40Q2WS6334z9s0n for ; Tue, 17 Apr 2018 08:05:40 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbeDPWFF (ORCPT ); Mon, 16 Apr 2018 18:05:05 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:43871 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752690AbeDPWE4 (ORCPT ); Mon, 16 Apr 2018 18:04:56 -0400 Received: by mail-pf0-f194.google.com with SMTP id j11so4628623pff.10; Mon, 16 Apr 2018 15:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QfsGzPD1azqmqyKMiCdo081PSuc7Aldz4G9buENstOg=; b=GSZdA7YjUhVWg3fsohF4604Vr/lJtOa/gD+N2ImkbY42BzXo1k2Zhb4qxTpFImxbtT w4376pQouLCkergNBNWxCbo98f1SOfHFKptWDhLgUpa+M7cV9LEw2CCSOAoAp+DPSu11 x8xgpf6f5/G/jyvVHni+ty6JF5+LvBh3RbMjk72NMOwPZcLuPxeaYxY5zmIFxzsylODa HiyKDfI7E/za6TnihI7etoetkdYWSsWITydjU+EuAks+mE3u9Hg5UX8mholHk6gVblKo 1B7AaVttYrHK/fTTFqkgjL5UV3WVkCkWNFeC5rUJY5vDdCBVC6wRwTpclRjg0HXwITqz 2psw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QfsGzPD1azqmqyKMiCdo081PSuc7Aldz4G9buENstOg=; b=b/b68VX7Xrsk1Kx+kRNL+HI/jeS2PXLrncGfY0RedSkICsjBEbLbrZO+N8GJ+1BMLX KbKrWJKpExnwjpZJd9XNIwtJRNqub6Kf009Pr4A9VD7DYMxmeH4tfv1rLRGH80kKLXB8 eQIbZYypsoDh/4Pk8XX29qC1ARAfjqCVgyKaTnkJyMFKIKhVCxUQMzLRVeCFPMLTxMaX P0X3WTW7LI1MK5wEvp2wDkptBR7LQP1JsONBwAc1GyZikhVjyVKU1nXpssNXIIhEj4/g Qtkus4usLNJ0a2G6YoeSxe4eTHPilo9qGcZ5aaozwTjhvb6aSZ+99m58I0epluO2IXM0 BoNg== X-Gm-Message-State: ALQs6tC7Pln5+HpMTDnl8CY/WqnMBdTkxCjTCHJ/BpC3EFka2deEr4wx ZinZ4XtwY2X9uXAI/Vu2CsM= X-Google-Smtp-Source: AIpwx4+gVayCNFwEOLZjPETdw3FplbwLjRBnotTWoad77o4hyc7YsumxNPkDmevNDhn73JnuoU1avw== X-Received: by 10.99.168.66 with SMTP id i2mr14455847pgp.367.1523916295944; Mon, 16 Apr 2018 15:04:55 -0700 (PDT) Received: from xplor.waratah.dyndns.org (222-154-41-72-adsl.bb.spark.co.nz. [222.154.41.72]) by smtp.gmail.com with ESMTPSA id s7sm19775858pgq.48.2018.04.16.15.04.52 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 16 Apr 2018 15:04:53 -0700 (PDT) Received: by xplor.waratah.dyndns.org (Postfix, from userid 1000) id 43D85360082; Tue, 17 Apr 2018 10:04:49 +1200 (NZST) From: Michael Schmitz To: netdev@vger.kernel.org Cc: linux-m68k@vger.kernel.org, Michael.Karcher@fu-berlin.de, John Paul Adrian Glaubitz , Michael Karcher Subject: [PATCH 03/10] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()). Date: Tue, 17 Apr 2018 10:04:38 +1200 Message-Id: <1523916285-6057-4-git-send-email-schmitzmic@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1523916285-6057-1-git-send-email-schmitzmic@gmail.com> References: <1523916285-6057-1-git-send-email-schmitzmic@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: John Paul Adrian Glaubitz This complements the fix in 82533ad9a1c that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the effects of probe. Signed-off-by: Michael Karcher --- drivers/net/ethernet/8390/ax88796.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/ethernet/8390/ax88796.c index f7b8911..a4f23ba 100644 --- a/drivers/net/ethernet/8390/ax88796.c +++ b/drivers/net/ethernet/8390/ax88796.c @@ -791,7 +791,6 @@ static int ax_remove(struct platform_device *pdev) struct resource *mem; unregister_netdev(dev); - free_irq(dev->irq, dev); iounmap(ei_local->mem); mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);