| Message ID | 20180416202637.13400-1-aserdean@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] ovsdb-tool.at: Drop monitor argument | expand |
On Mon, Apr 16, 2018 at 11:26:37PM +0300, Alin Gabriel Serdean wrote: > This patch drops the '--monitor' argument when running the ovsdb-server. > > This can potentially increase the bug detection since the process will not > be restarted in certain situations. > > Also, fixes the test under Windows since daemons do not have '--monitor' > argument. > > Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> Thanks! Acked-by: Ben Pfaff <blp@ovn.org>
> On 16 Apr 2018, at 23:41, Ben Pfaff <blp@ovn.org> wrote: > > On Mon, Apr 16, 2018 at 11:26:37PM +0300, Alin Gabriel Serdean wrote: >> This patch drops the '--monitor' argument when running the ovsdb-server. >> >> This can potentially increase the bug detection since the process will not >> be restarted in certain situations. >> >> Also, fixes the test under Windows since daemons do not have '--monitor' >> argument. >> >> Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> > > Thanks! > > Acked-by: Ben Pfaff <blp@ovn.org> Thanks for the quick review! I added a Suggested-by/at and applied on master.
diff --git a/tests/ovsdb-tool.at b/tests/ovsdb-tool.at index ab766be24..a27a239ea 100644 --- a/tests/ovsdb-tool.at +++ b/tests/ovsdb-tool.at @@ -443,7 +443,7 @@ AT_CHECK( ]], [ignore]) # Dump the data. -AT_CHECK([ovsdb-server -vfile -vvlog:off --monitor --detach --no-chdir --pidfile --log-file --remote=punix:db.sock db1]) +AT_CHECK([ovsdb-server -vfile -vvlog:off --detach --no-chdir --pidfile --log-file --remote=punix:db.sock db1]) AT_CHECK([ovsdb-client dump > expout]) OVS_APP_EXIT_AND_WAIT([ovsdb-server]) @@ -451,7 +451,7 @@ OVS_APP_EXIT_AND_WAIT([ovsdb-server]) ovsdb-tool create-cluster db2 db1 unix:s1.raft # Dump the data. -AT_CHECK([ovsdb-server -vconsole:off -vfile -vvlog:off --monitor --detach --no-chdir --pidfile --log-file --remote=punix:db.sock db2]) +AT_CHECK([ovsdb-server -vconsole:off -vfile -vvlog:off --detach --no-chdir --pidfile --log-file --remote=punix:db.sock db2]) AT_CHECK([ovsdb-client wait ordinals connected]) AT_CHECK([ovsdb-client dump > dump2]) OVS_APP_EXIT_AND_WAIT([ovsdb-server])
This patch drops the '--monitor' argument when running the ovsdb-server. This can potentially increase the bug detection since the process will not be restarted in certain situations. Also, fixes the test under Windows since daemons do not have '--monitor' argument. Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org> --- tests/ovsdb-tool.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)