| Message ID | 1302015561-21047-20-git-send-email-mmarek@suse.cz |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Apr 5, 2011 at 4:59 PM, Michal Marek <mmarek@suse.cz> wrote: > The kernel already prints its build timestamp during boot, no need to > repeat it in random drivers and produce different object files each > time. > > Cc: Ivo van Doorn <IvDoorn@gmail.com> > Cc: Gertjan van Wingerde <gwingerde@gmail.com> > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Michal Marek <mmarek@suse.cz> Note that this timestamp is not in the kernel log, but in a special debug file in debugfs. However, I cannot see how a timestamp is actually useful for debugging the driver, so Acked-by: Gertjan van Wingerde <gwingerde@gmail.com> > --- > drivers/net/wireless/rt2x00/rt2x00debug.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c > index c92db32..66166ef 100644 > --- a/drivers/net/wireless/rt2x00/rt2x00debug.c > +++ b/drivers/net/wireless/rt2x00/rt2x00debug.c > @@ -568,7 +568,6 @@ static struct dentry *rt2x00debug_create_file_driver(const char *name, > blob->data = data; > data += sprintf(data, "driver:\t%s\n", intf->rt2x00dev->ops->name); > data += sprintf(data, "version:\t%s\n", DRV_VERSION); > - data += sprintf(data, "compiled:\t%s %s\n", __DATE__, __TIME__); > blob->size = strlen(blob->data); > > return debugfs_create_blob(name, S_IRUSR, intf->driver_folder, blob); > -- > 1.7.4.1 > >
On Tue, Apr 5, 2011 at 4:59 PM, Michal Marek <mmarek@suse.cz> wrote: > The kernel already prints its build timestamp during boot, no need to > repeat it in random drivers and produce different object files each > time. > > Cc: Ivo van Doorn <IvDoorn@gmail.com> > Cc: Gertjan van Wingerde <gwingerde@gmail.com> > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Michal Marek <mmarek@suse.cz> Acked-by: Ivo van Doorn <IvDoorn@gmail.com> > --- > drivers/net/wireless/rt2x00/rt2x00debug.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c > index c92db32..66166ef 100644 > --- a/drivers/net/wireless/rt2x00/rt2x00debug.c > +++ b/drivers/net/wireless/rt2x00/rt2x00debug.c > @@ -568,7 +568,6 @@ static struct dentry *rt2x00debug_create_file_driver(const char *name, > blob->data = data; > data += sprintf(data, "driver:\t%s\n", intf->rt2x00dev->ops->name); > data += sprintf(data, "version:\t%s\n", DRV_VERSION); > - data += sprintf(data, "compiled:\t%s %s\n", __DATE__, __TIME__); > blob->size = strlen(blob->data); > > return debugfs_create_blob(name, S_IRUSR, intf->driver_folder, blob); > -- > 1.7.4.1 > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c index c92db32..66166ef 100644 --- a/drivers/net/wireless/rt2x00/rt2x00debug.c +++ b/drivers/net/wireless/rt2x00/rt2x00debug.c @@ -568,7 +568,6 @@ static struct dentry *rt2x00debug_create_file_driver(const char *name, blob->data = data; data += sprintf(data, "driver:\t%s\n", intf->rt2x00dev->ops->name); data += sprintf(data, "version:\t%s\n", DRV_VERSION); - data += sprintf(data, "compiled:\t%s %s\n", __DATE__, __TIME__); blob->size = strlen(blob->data); return debugfs_create_blob(name, S_IRUSR, intf->driver_folder, blob);
The kernel already prints its build timestamp during boot, no need to repeat it in random drivers and produce different object files each time. Cc: Ivo van Doorn <IvDoorn@gmail.com> Cc: Gertjan van Wingerde <gwingerde@gmail.com> Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Michal Marek <mmarek@suse.cz> --- drivers/net/wireless/rt2x00/rt2x00debug.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)