Patchwork [PATCHv1,1/5] tests: checkfs: fix compiler warnings

login
register
mail settings
Submitter Shevchenko Andriy (EXT-Teleca/Helsinki)
Date April 5, 2011, 1:55 p.m.
Message ID <f17ef71846bf870b69b04127ac0d7d924678ebee.1302011698.git.ext-andriy.shevchenko@nokia.com>
Download mbox | patch
Permalink /patch/89867/
State Accepted
Commit 30e39ef877a3d039e31b19065afe37d643f82f12
Headers show

Comments

Shevchenko Andriy (EXT-Teleca/Helsinki) - April 5, 2011, 1:55 p.m.
There are two warnings:
 - strlen() is used without prototype
 - argument of printf() is unsigned long, but used specifier is for int

This patch fixes them.

Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
---
 tests/checkfs/checkfs.c |    2 +-
 tests/checkfs/comm.c    |    5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)
Artem Bityutskiy - April 5, 2011, 2:08 p.m.
On Tue, 2011-04-05 at 16:55 +0300, Andy Shevchenko wrote:
> There are two warnings:
>  - strlen() is used without prototype
>  - argument of printf() is unsigned long, but used specifier is for int
> 
> This patch fixes them.
> 
> Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>

Pushed to mtd-utils.git, thanks.

Patch

diff --git a/tests/checkfs/checkfs.c b/tests/checkfs/checkfs.c
index da2d0c4..6ca2c0e 100644
--- a/tests/checkfs/checkfs.c
+++ b/tests/checkfs/checkfs.c
@@ -520,7 +520,7 @@  void processCmdLine(int argc, char **argv)
                 FileSizeMax = (float)atoi(argv[++cnt]);
                 if(FileSizeMax > (MAX_INTS_ALLOW*sizeof(int)))
                 {
-                    printf("Max file size allowd is %i.\n",
+                    printf("Max file size allowed is %lu.\n",
                            MAX_INTS_ALLOW*sizeof(int));
                     exit(0);
                 }
diff --git a/tests/checkfs/comm.c b/tests/checkfs/comm.c
index 57fc7ed..881a270 100644
--- a/tests/checkfs/comm.c
+++ b/tests/checkfs/comm.c
@@ -21,15 +21,12 @@ 
   Split the modbus comm part of the program (that sends the ok to pwr me down
   message) into another file "comm.c"
 
-
-
  */
 
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
-
-
+#include <string.h>
 
 /*
   This is the routine that forms and