| Message ID | 20180416112724.9677-2-aneesh.kumar@linux.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | powerpc/8xx: Build fix with Hugetlbfs enabled | expand |
Le 16/04/2018 à 13:27, Aneesh Kumar K.V a écrit : > 8xx use slice code when hugetlbfs is enabled. We missed a header include on > 8xx which resulted in the below build failure. > > config: mpc885_ads_defconfig + CONFIG_HUGETLBFS > > CC arch/powerpc/mm/slice.o > arch/powerpc/mm/slice.c: In function 'slice_get_unmapped_area': > arch/powerpc/mm/slice.c:655:2: error: implicit declaration of function 'need_extra_context' [-Werror=implicit-function-declaration] > arch/powerpc/mm/slice.c:656:3: error: implicit declaration of function 'alloc_extended_context' [-Werror=implicit-function-declaration] > cc1: all warnings being treated as errors > make[1]: *** [arch/powerpc/mm/slice.o] Error 1 > make: *** [arch/powerpc/mm] Error 2 > > on PPC64 the mmu_context.h was included via linux/pkeys.h > > CC: Christophe LEROY <christophe.leroy@c-s.fr> > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> Tested-by: Christophe Leroy <christophe.leroy@c-s.fr> > --- > arch/powerpc/mm/slice.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/mm/slice.c b/arch/powerpc/mm/slice.c > index 9cd87d11fe4e..205fe557ca10 100644 > --- a/arch/powerpc/mm/slice.c > +++ b/arch/powerpc/mm/slice.c > @@ -35,6 +35,7 @@ > #include <asm/mmu.h> > #include <asm/copro.h> > #include <asm/hugetlb.h> > +#include <asm/mmu_context.h> > > static DEFINE_SPINLOCK(slice_convert_lock); > >
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes: > 8xx use slice code when hugetlbfs is enabled. We missed a header include on > 8xx which resulted in the below build failure. > > config: mpc885_ads_defconfig + CONFIG_HUGETLBFS > > CC arch/powerpc/mm/slice.o > arch/powerpc/mm/slice.c: In function 'slice_get_unmapped_area': > arch/powerpc/mm/slice.c:655:2: error: implicit declaration of function 'need_extra_context' [-Werror=implicit-function-declaration] > arch/powerpc/mm/slice.c:656:3: error: implicit declaration of function 'alloc_extended_context' [-Werror=implicit-function-declaration] > cc1: all warnings being treated as errors > make[1]: *** [arch/powerpc/mm/slice.o] Error 1 > make: *** [arch/powerpc/mm] Error 2 > > on PPC64 the mmu_context.h was included via linux/pkeys.h > > CC: Christophe LEROY <christophe.leroy@c-s.fr> > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> > --- > arch/powerpc/mm/slice.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/mm/slice.c b/arch/powerpc/mm/slice.c > index 9cd87d11fe4e..205fe557ca10 100644 > --- a/arch/powerpc/mm/slice.c > +++ b/arch/powerpc/mm/slice.c > @@ -35,6 +35,7 @@ > #include <asm/mmu.h> > #include <asm/copro.h> > #include <asm/hugetlb.h> > +#include <asm/mmu_context.h> I already merged this, didn't I? cheers
Michael Ellerman <mpe@ellerman.id.au> writes: > "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes: > >> 8xx use slice code when hugetlbfs is enabled. We missed a header include on >> 8xx which resulted in the below build failure. >> >> config: mpc885_ads_defconfig + CONFIG_HUGETLBFS >> >> CC arch/powerpc/mm/slice.o >> arch/powerpc/mm/slice.c: In function 'slice_get_unmapped_area': >> arch/powerpc/mm/slice.c:655:2: error: implicit declaration of function 'need_extra_context' [-Werror=implicit-function-declaration] >> arch/powerpc/mm/slice.c:656:3: error: implicit declaration of function 'alloc_extended_context' [-Werror=implicit-function-declaration] >> cc1: all warnings being treated as errors >> make[1]: *** [arch/powerpc/mm/slice.o] Error 1 >> make: *** [arch/powerpc/mm] Error 2 >> >> on PPC64 the mmu_context.h was included via linux/pkeys.h >> >> CC: Christophe LEROY <christophe.leroy@c-s.fr> >> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> >> --- >> arch/powerpc/mm/slice.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/powerpc/mm/slice.c b/arch/powerpc/mm/slice.c >> index 9cd87d11fe4e..205fe557ca10 100644 >> --- a/arch/powerpc/mm/slice.c >> +++ b/arch/powerpc/mm/slice.c >> @@ -35,6 +35,7 @@ >> #include <asm/mmu.h> >> #include <asm/copro.h> >> #include <asm/hugetlb.h> >> +#include <asm/mmu_context.h> > > I already merged this, didn't I? > yes. This patch was wrongly included in this series. -aneesh
diff --git a/arch/powerpc/mm/slice.c b/arch/powerpc/mm/slice.c index 9cd87d11fe4e..205fe557ca10 100644 --- a/arch/powerpc/mm/slice.c +++ b/arch/powerpc/mm/slice.c @@ -35,6 +35,7 @@ #include <asm/mmu.h> #include <asm/copro.h> #include <asm/hugetlb.h> +#include <asm/mmu_context.h> static DEFINE_SPINLOCK(slice_convert_lock);
8xx use slice code when hugetlbfs is enabled. We missed a header include on 8xx which resulted in the below build failure. config: mpc885_ads_defconfig + CONFIG_HUGETLBFS CC arch/powerpc/mm/slice.o arch/powerpc/mm/slice.c: In function 'slice_get_unmapped_area': arch/powerpc/mm/slice.c:655:2: error: implicit declaration of function 'need_extra_context' [-Werror=implicit-function-declaration] arch/powerpc/mm/slice.c:656:3: error: implicit declaration of function 'alloc_extended_context' [-Werror=implicit-function-declaration] cc1: all warnings being treated as errors make[1]: *** [arch/powerpc/mm/slice.o] Error 1 make: *** [arch/powerpc/mm] Error 2 on PPC64 the mmu_context.h was included via linux/pkeys.h CC: Christophe LEROY <christophe.leroy@c-s.fr> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> --- arch/powerpc/mm/slice.c | 1 + 1 file changed, 1 insertion(+)