Message ID | CAEUhbmWzbR3v9BhzAnPQbUyyj2sejfkcFAugqx96=OzBy93RHA@mail.gmail.com |
---|---|
State | Superseded |
Headers | show |
Series | [U-Boot] Please pull u-boot-x86 | expand |
On Mon, Apr 16, 2018 at 05:17:30PM +0800, Bin Meng wrote: > Hi Tom, > > This includes some fixes and enhancements to VxWorks booting support, > as well as some mods to x86 I/O functions. > > The following changes since commit ebca902aeb3af3eaedd2787928184ad84a86b98f: > > Merge git://git.denx.de/u-boot-imx (2018-04-15 08:43:50 -0400) > > are available in the git repository at: > > git://git.denx.de/u-boot-x86.git > > for you to fetch changes up to 699b8a1386255252293d743a0b196232641167f3: > > x86: Rename coreboot-x86 to coreboot (2018-04-16 16:54:51 +0800) > NAK. This breaks most non-x86 as follows: m68k: + M5485BFE +(M5485BFE) ../cmd/elf.c: In function ?do_bootvx?: +(M5485BFE) ../cmd/elf.c:346:15: error: ?base? undeclared (first use in this function) +(M5485BFE) bootaddr = base + X86_BOOT_LINE_OFFSET; +(M5485BFE) ^~~~ +(M5485BFE) ../cmd/elf.c:346:15: note: each undeclared identifier is reported only once for each function it appears in +(M5485BFE) make[2]: *** [cmd/elf.o] Error 1 +(M5485BFE) make[1]: *** [cmd] Error 2 +(M5485BFE) make: *** [sub-make] Error 2
Hi Tom, On Mon, Apr 16, 2018 at 8:31 PM, Tom Rini <trini@konsulko.com> wrote: > On Mon, Apr 16, 2018 at 05:17:30PM +0800, Bin Meng wrote: > >> Hi Tom, >> >> This includes some fixes and enhancements to VxWorks booting support, >> as well as some mods to x86 I/O functions. >> >> The following changes since commit ebca902aeb3af3eaedd2787928184ad84a86b98f: >> >> Merge git://git.denx.de/u-boot-imx (2018-04-15 08:43:50 -0400) >> >> are available in the git repository at: >> >> git://git.denx.de/u-boot-x86.git >> >> for you to fetch changes up to 699b8a1386255252293d743a0b196232641167f3: >> >> x86: Rename coreboot-x86 to coreboot (2018-04-16 16:54:51 +0800) >> > > NAK. This breaks most non-x86 as follows: > m68k: + M5485BFE > +(M5485BFE) ../cmd/elf.c: In function ?do_bootvx?: > +(M5485BFE) ../cmd/elf.c:346:15: error: ?base? undeclared (first use in this function) > +(M5485BFE) bootaddr = base + X86_BOOT_LINE_OFFSET; > +(M5485BFE) ^~~~ > +(M5485BFE) ../cmd/elf.c:346:15: note: each undeclared identifier is reported only once for each function it appears in > +(M5485BFE) make[2]: *** [cmd/elf.o] Error 1 > +(M5485BFE) make[1]: *** [cmd] Error 2 > +(M5485BFE) make: *** [sub-make] Error 2 Sorry about this. I will send v2 pull request. Regards, Bin