| Message ID | alpine.DEB.2.20.1804120752280.3559@hadrien |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | drm: fix drm-get-put.cocci warnings | expand |
On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote: > From: Fengguang Wu <fengguang.wu@intel.com> > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > drm_*_unreference() helpers. > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver") > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > --- > > tree: https://github.com/shenki/linux drm-v1 This isn't an upstream tree (and the aspeed driver isn't in upstream afaict), so no need for spamming mailing lists I think. But thanks for doing all this, great motivation to put more of the drm refactorings into cocci files. Cheers, Daniel > head: 9680ed7979d5d403c6bde36271a048d62c048180 > commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add ASPEED > GFX > driver > > aspeed_gfx_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > @@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf > err_unload: > aspeed_gfx_unload(drm); > err_free: > - drm_dev_unref(drm); > + drm_dev_put(drm); > > return ret; > } > @@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat > > drm_dev_unregister(drm); > aspeed_gfx_unload(drm); > - drm_dev_unref(drm); > + drm_dev_put(drm); > > return 0; > } > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 16 April 2018 at 17:15, Daniel Vetter <daniel@ffwll.ch> wrote: > On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote: >> From: Fengguang Wu <fengguang.wu@intel.com> >> >> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and >> drm_*_unreference() helpers. >> >> Generated by: scripts/coccinelle/api/drm-get-put.cocci >> >> Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver") >> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> >> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> >> --- >> >> tree: https://github.com/shenki/linux drm-v1 > > This isn't an upstream tree (and the aspeed driver isn't in upstream > afaict), so no need for spamming mailing lists I think. Agreed. Julia, I am happy getting a heads up about changes from the 0day bots, but I would prefer not to spam others or the lists. If we can't restrict the emails to just me then perhaps it's best to disable them for github.com/shenki/linux.git. FWIW, the aspeed gfx driver has been posted to dri-devel so it will be upstream soon-ish. Cheers, Joel
On Mon, 16 Apr 2018, Daniel Vetter wrote: > On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote: > > From: Fengguang Wu <fengguang.wu@intel.com> > > > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > > drm_*_unreference() helpers. > > > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > > > Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver") > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > > --- > > > > tree: https://github.com/shenki/linux drm-v1 > > This isn't an upstream tree (and the aspeed driver isn't in upstream > afaict), so no need for spamming mailing lists I think. Perhaps you can contact Fengguang about this? I just forward to whoever the automatically generated message says to forward to. And I don't always remember to include the information about the tree, which comes to me in another message, so it can indeed be confusing. > > But thanks for doing all this, great motivation to put more of the drm > refactorings into cocci files. Most welcome :) julia > Cheers, Daniel > > head: 9680ed7979d5d403c6bde36271a048d62c048180 > > commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add ASPEED > > GFX > > driver > > > > aspeed_gfx_drv.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > > @@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf > > err_unload: > > aspeed_gfx_unload(drm); > > err_free: > > - drm_dev_unref(drm); > > + drm_dev_put(drm); > > > > return ret; > > } > > @@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat > > > > drm_dev_unregister(drm); > > aspeed_gfx_unload(drm); > > - drm_dev_unref(drm); > > + drm_dev_put(drm); > > > > return 0; > > } > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch >
> Subject: Re: [kbuild-all] [PATCH] drm: fix drm-get-put.cocci warnings > > On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote: > > From: Fengguang Wu <fengguang.wu@intel.com> > > > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > > drm_*_unreference() helpers. > > > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > > > Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver") > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > > --- > > > > tree: https://github.com/shenki/linux drm-v1 > > This isn't an upstream tree (and the aspeed driver isn't in upstream > afaict), so no need for spamming mailing lists I think. thanks for feedback Daniel, we will mark this repo as private one to avoid reporting to larger mailing list. > > But thanks for doing all this, great motivation to put more of the drm > refactorings into cocci files. > > Cheers, Daniel > > head: 9680ed7979d5d403c6bde36271a048d62c048180 > > commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add > ASPEED > > GFX > > driver > > > > aspeed_gfx_drv.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > > @@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf > > err_unload: > > aspeed_gfx_unload(drm); > > err_free: > > - drm_dev_unref(drm); > > + drm_dev_put(drm); > > > > return ret; > > } > > @@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat > > > > drm_dev_unregister(drm); > > aspeed_gfx_unload(drm); > > - drm_dev_unref(drm); > > + drm_dev_put(drm); > > > > return 0; > > } > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > _______________________________________________ > kbuild-all mailing list > kbuild-all@lists.01.org > https://lists.01.org/mailman/listinfo/kbuild-all
--- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c @@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf err_unload: aspeed_gfx_unload(drm); err_free: - drm_dev_unref(drm); + drm_dev_put(drm); return ret; } @@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat drm_dev_unregister(drm); aspeed_gfx_unload(drm); - drm_dev_unref(drm); + drm_dev_put(drm); return 0; }