[V2] of: Don't create device for OPP tables

Message ID 469dfad07762787ea2cf446d71d355c0b5d969b3.1523863527.git.viresh.kumar@linaro.org
State Superseded
Headers show
Series
  • [V2] of: Don't create device for OPP tables
Related show

Commit Message

Viresh Kumar April 16, 2018, 7:26 a.m.
The OPP tables are present as separate nodes, whose phandle is used in
the "operating-points-v2" property of devices. Currently the OF core
creates a device for the OPP table unconditionally, which is not used by
any kernel code.

This patch creates another OF device_id table for the nodes which must
be skipped while creating devices and OPP is the only user of it for now.

Reported-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
---
V1->V2:
- Added Reviewed-by from Stephen.
- Created a table for nodes to be skipped.

 drivers/of/platform.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Stephen Boyd April 16, 2018, 3:20 p.m. | #1
Quoting Viresh Kumar (2018-04-16 00:26:21)
> ---
> V1->V2:
> - Added Reviewed-by from Stephen.

Ok

> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index c00d81dfac0b..93aff2bf56f9 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -32,6 +32,11 @@ const struct of_device_id of_default_bus_match_table[] = {
>         {} /* Empty terminated list */
>  };
>  
> +const struct of_device_id of_skipped_node_table[] = {

static?

> +       { .compatible = "operating-points-v2", },
> +       {} /* Empty terminated list */
> +};
> +
>  static int of_dev_node_match(struct device *dev, void *data)
>  {
>         return dev->of_node == data;
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index c00d81dfac0b..93aff2bf56f9 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -32,6 +32,11 @@  const struct of_device_id of_default_bus_match_table[] = {
 	{} /* Empty terminated list */
 };
 
+const struct of_device_id of_skipped_node_table[] = {
+	{ .compatible = "operating-points-v2", },
+	{} /* Empty terminated list */
+};
+
 static int of_dev_node_match(struct device *dev, void *data)
 {
 	return dev->of_node == data;
@@ -356,6 +361,12 @@  static int of_platform_bus_create(struct device_node *bus,
 		return 0;
 	}
 
+	/* Skip nodes for which we don't want to create devices */
+	if (unlikely(of_match_node(of_skipped_node_table, bus))) {
+		pr_debug("%s() - skipping %pOF node\n", __func__, bus);
+		return 0;
+	}
+
 	if (of_node_check_flag(bus, OF_POPULATED_BUS)) {
 		pr_debug("%s() - skipping %pOF, already populated\n",
 			__func__, bus);