From patchwork Sun Apr 15 23:42:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 898382 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nKIw/1fE"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40PTCy2zlyz9s0b for ; Mon, 16 Apr 2018 10:05:18 +1000 (AEST) Received: from localhost ([::1]:52856 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7re0-0005Je-9k for incoming@patchwork.ozlabs.org; Sun, 15 Apr 2018 20:05:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7rJh-00056n-VJ for qemu-devel@nongnu.org; Sun, 15 Apr 2018 19:44:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7rJh-0000jl-8K for qemu-devel@nongnu.org; Sun, 15 Apr 2018 19:44:18 -0400 Received: from mail-qt0-x233.google.com ([2607:f8b0:400d:c0d::233]:41577) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f7rJc-0000gw-Hw; Sun, 15 Apr 2018 19:44:12 -0400 Received: by mail-qt0-x233.google.com with SMTP id d3so13550279qth.8; Sun, 15 Apr 2018 16:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NS6kuGGNOszLMRacyerCPiwBYscCC1qHvmL3qXECWpY=; b=nKIw/1fE88HM1N/3lkkD3yFxJhNFXZ4buPUB+jIK7DwrNzzicmqWmhmnKDvMRQ9tGt 5N8TI7fu9QePxdy5rH4BiUqietDYe4lGnNQTIGWpwXlVEaedkC1/YEkQ2/vDHwhWcc8B C3ztevO01Ci4Um8+xLh/cy3kOtBv6Xk2eBqA9eWdz3RTwKPaAcJAV/vWIw+q7JE3Ag/j Hc5xCFJwoPtVfZvnOMIfkU9jRt8e43yc/XupKkRrPUdCR909UOIRaWLhelCE534DSO8v qsMUFth6rmLzuTqkwmjDGTngUqEqXBG3ZvZTc4DE67xTcZR/33KC7fd3A3+mViMZRocN vE/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=NS6kuGGNOszLMRacyerCPiwBYscCC1qHvmL3qXECWpY=; b=ptZ06K9lXq4H8hiapOlSN0RtBzNG1CqQQCHS29BrrKwnzbHTnvVQqvlR2XJwA4nWpo 9AdLsJycicdcX+XlK8V9L86auFjjYToy+vGTVglUlck9zyLVH7n5fdlKCgVPYYWIElqf znpgv8J7vVAnA/5wvN0wNYI54j1UjaIwVhlZkOyQ7kI6bI9nedYQFizd/2Cg/G/WzyJ3 az26gDnlTRiPtu1w792TortLBDvd0I+VOQGwIovDyf+5eDwkkBP8RZyMHrq+p8Dchusa HOhZ5emD72HPCxfhmyOdRqGcoLgF1Bbue7E80zDEtwGJMBKtGgQ00BPDRpUfjIUbRhNa KLpA== X-Gm-Message-State: ALQs6tAtnlSpxSub3BQ9V5G1/diq6Y13bxKos1BEyz1eUgl/vFQMDkrF BlrATKnSlBnrwpPDI1BytpwPWoTb X-Google-Smtp-Source: AIpwx489LWGMC8HAEVHdzSENrOOAv4xGAbkk/TqpVJAFgLanGYeoeyjopKTI6I05for8N4AcCAkSsg== X-Received: by 10.200.102.131 with SMTP id d3mr14368474qtp.305.1523835851853; Sun, 15 Apr 2018 16:44:11 -0700 (PDT) Received: from x1.local ([138.117.48.212]) by smtp.gmail.com with ESMTPSA id d1sm1081394qtk.57.2018.04.15.16.44.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Apr 2018 16:44:11 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-trivial@nongnu.org, Thomas Huth Date: Sun, 15 Apr 2018 20:42:43 -0300 Message-Id: <20180415234307.28132-18-f4bug@amsat.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180415234307.28132-1-f4bug@amsat.org> References: <20180415234307.28132-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::233 Subject: [Qemu-devel] [PATCH v3 17/41] hw/m68k: Use the BYTE-based definitions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/m68k/mcf5208.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c index fac0d09cbc..673d65f8fd 100644 --- a/hw/m68k/mcf5208.c +++ b/hw/m68k/mcf5208.c @@ -6,6 +6,7 @@ * This code is licensed under the GPL */ #include "qemu/osdep.h" +#include "qemu/units.h" #include "qemu/error-report.h" #include "qapi/error.h" #include "qemu-common.h" @@ -241,7 +242,7 @@ static void mcf5208evb_init(MachineState *machine) memory_region_add_subregion(address_space_mem, 0x40000000, ram); /* Internal SRAM. */ - memory_region_init_ram(sram, NULL, "mcf5208.sram", 16384, &error_fatal); + memory_region_init_ram(sram, NULL, "mcf5208.sram", 16 * K_BYTE, &error_fatal); memory_region_add_subregion(address_space_mem, 0x80000000, sram); /* Internal peripherals. */