From patchwork Sat Apr 14 18:51:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dinh Nguyen X-Patchwork-Id: 898182 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40NkT36wH8z9s0n for ; Sun, 15 Apr 2018 04:59:03 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id A3810C21E7F; Sat, 14 Apr 2018 18:53:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id B7E1AC21E16; Sat, 14 Apr 2018 18:52:20 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id CBEA8C21DA2; Sat, 14 Apr 2018 18:52:13 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by lists.denx.de (Postfix) with ESMTPS id DF3E7C21E47 for ; Sat, 14 Apr 2018 18:52:08 +0000 (UTC) Received: from localhost.localdomain (cpe-70-114-128-244.austin.res.rr.com [70.114.128.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A60A9217A6; Sat, 14 Apr 2018 18:52:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A60A9217A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dinguyen@kernel.org From: Dinh Nguyen To: u-boot@lists.denx.de Date: Sat, 14 Apr 2018 13:51:36 -0500 Message-Id: <1523731900-4675-11-git-send-email-dinguyen@kernel.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523731900-4675-1-git-send-email-dinguyen@kernel.org> References: <1523731900-4675-1-git-send-email-dinguyen@kernel.org> Cc: marex@denx.de, joe.hershberger@ni.com, jagan@openedev.com Subject: [U-Boot] [PATCHv1 10/14] net: dwc_eth_qos: remove reset_free from driver X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The call to free the reset control line is a deadend call that doesn't lead to any reset control functionality. Also the reset_free() function will be remove in a subsequent patch, so remove it here. Signed-off-by: Dinh Nguyen --- drivers/net/dwc_eth_qos.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c index 232e803..a3f1b40 100644 --- a/drivers/net/dwc_eth_qos.c +++ b/drivers/net/dwc_eth_qos.c @@ -1371,7 +1371,6 @@ static int eqos_probe_resources_tegra186(struct udevice *dev) GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE); if (ret) { pr_err("gpio_request_by_name(phy reset) failed: %d", ret); - goto err_free_reset_eqos; } ret = clk_get_by_name(dev, "slave_bus", &eqos->clk_slave_bus); @@ -1418,8 +1417,6 @@ err_free_clk_slave_bus: clk_free(&eqos->clk_slave_bus); err_free_gpio_phy_reset: dm_gpio_free(dev, &eqos->phy_reset_gpio); -err_free_reset_eqos: - reset_free(&eqos->reset_ctl); debug("%s: returns %d\n", __func__, ret); return ret; @@ -1437,7 +1434,6 @@ static int eqos_remove_resources_tegra186(struct udevice *dev) clk_free(&eqos->clk_slave_bus); clk_free(&eqos->clk_master_bus); dm_gpio_free(dev, &eqos->phy_reset_gpio); - reset_free(&eqos->reset_ctl); debug("%s: OK\n", __func__); return 0;