From patchwork Wed Apr 11 17:41:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Mostafa X-Patchwork-Id: 897326 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id 40Lrvf1tfXz9s3L; Thu, 12 Apr 2018 03:42:05 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1f6Jkr-0002x2-LD; Wed, 11 Apr 2018 17:41:57 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1f6Jkp-0002wt-Rg for kernel-team@lists.ubuntu.com; Wed, 11 Apr 2018 17:41:55 +0000 Received: from 1.general.kamal.us.vpn ([10.172.68.52] helo=fourier) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1f6Jkp-0005TE-Fb for kernel-team@lists.ubuntu.com; Wed, 11 Apr 2018 17:41:55 +0000 Received: from kamal by fourier with local (Exim 4.86_2) (envelope-from ) id 1f6Jkn-0004o4-78 for kernel-team@lists.ubuntu.com; Wed, 11 Apr 2018 10:41:53 -0700 From: Kamal Mostafa To: kernel-team@lists.ubuntu.com Subject: [linux-kvm][PATCH] UBUNTU: kvm: [Config] CONFIG_UNWINDER_FRAME_POINTER=y for amd64 Date: Wed, 11 Apr 2018 10:41:52 -0700 Message-Id: <1523468512-18428-1-git-send-email-kamal@canonical.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Seth Forshee BugLink: http://bugs.launchpad.net/bugs/1763107 During the rebase to 4.15 UNWINDER_ORC was chosen as the stack unwinder as it promises a 5-10% performance improvement over using UNWINDER_FRAME_POINTER. However it turns out to have a couple of downsides. It adds a new requierment for building dkms modules, and it does not produce the reliable stack traces required for livepatch. Switch back to UNWINDER_FRAME_POINTER. Signed-off-by: Seth Forshee Signed-off-by: Kamal Mostafa Acked-by: Thadeu Lima de Souza Cascardo --- debian.kvm/config/config.common.ubuntu | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu index 2e46f80..3f29b63 100644 --- a/debian.kvm/config/config.common.ubuntu +++ b/debian.kvm/config/config.common.ubuntu @@ -724,6 +724,7 @@ CONFIG_FIX_EARLYCON_MEM=y # CONFIG_FMC is not set # CONFIG_FORTIFY_SOURCE is not set # CONFIG_FPGA is not set +CONFIG_FRAME_POINTER=y CONFIG_FRAME_WARN=2048 CONFIG_FREEZER=y # CONFIG_FRONTSWAP is not set @@ -883,6 +884,7 @@ CONFIG_HAVE_PERF_REGS=y CONFIG_HAVE_PERF_USER_STACK_DUMP=y CONFIG_HAVE_RCU_TABLE_FREE=y CONFIG_HAVE_REGS_AND_STACK_ACCESS_API=y +CONFIG_HAVE_RELIABLE_STACKTRACE=y CONFIG_HAVE_SETUP_PER_CPU_AREA=y CONFIG_HAVE_STACK_VALIDATION=y CONFIG_HAVE_SYSCALL_TRACEPOINTS=y @@ -2136,9 +2138,9 @@ CONFIG_UNIX=y CONFIG_UNIX98_PTYS=y # CONFIG_UNIX_DIAG is not set # CONFIG_UNUSED_SYMBOLS is not set -# CONFIG_UNWINDER_FRAME_POINTER is not set +CONFIG_UNWINDER_FRAME_POINTER=y # CONFIG_UNWINDER_GUESS is not set -CONFIG_UNWINDER_ORC=y +# CONFIG_UNWINDER_ORC is not set # CONFIG_UPROBES is not set CONFIG_USB_OHCI_LITTLE_ENDIAN=y # CONFIG_USB_SUPPORT is not set